Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarkus Dev Mode: xml resources seems ignored #16402

Closed
aldettinger opened this issue Apr 9, 2021 · 3 comments
Closed

Quarkus Dev Mode: xml resources seems ignored #16402

aldettinger opened this issue Apr 9, 2021 · 3 comments
Labels
area/devmode kind/bug Something isn't working triage/invalid This doesn't seem right

Comments

@aldettinger
Copy link

Describe the bug

I face a situation where changing an xml resources should trigger a quarkus dev restart while it's not the case.

Expected behavior

I would expected the dev mode to restart the service.

Actual behavior

The service is not restarted.

To Reproduce

git clone git@github.com:aldettinger/quarkus-devmode-restdsl-not-reloaded-reproducer.git
mvn quarkus:dev
http :8080/steps (output STEP 1 => ok)
In rests.xml, change "STEP 1" to "STEP 2" and save
http :8080/steps (output STEP 1 => ko)

Sometimes, no change is detected.
Sometimes, it displays "Files changed but restart not needed - notified extensions".
While any change in application.properties make the application reloaded which is great.

Is is possible that an xml resource always trigger reload like an application.properties file ? Via configuration ? Via an extension that would mark this file as restartNeeded ?

The closest issue I found is #16350, but not sure there is a link.

@aldettinger aldettinger added the kind/bug Something isn't working label Apr 9, 2021
@famod
Copy link
Member

famod commented Apr 9, 2021

@aldettinger
Copy link
Author

Many thanks @famod , it works like a charm to set it via configuration 👍
Now, I wonder what would be the correct way to handle this from an extension, maybe having an extension adding configuration is ok.

@famod
Copy link
Member

famod commented Apr 12, 2021

Glad it worked for you.

For extensions you should have a look at LiveReloadBuildItem. There should be plenty examples in the Quarkus code base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devmode kind/bug Something isn't working triage/invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants