Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devtools - BuildFile - possible NPE #16580

Closed
rsvoboda opened this issue Apr 16, 2021 · 0 comments · Fixed by #16636
Closed

devtools - BuildFile - possible NPE #16580

rsvoboda opened this issue Apr 16, 2021 · 0 comments · Fixed by #16636
Assignees
@aloubyansky
Labels
kind/bug Something isn't working
Milestone
2.0.0.Alpha1

Comments

@rsvoboda
Copy link
Member

https://github.com/quarkusio/quarkus/blob/main/independent-projects/tools/devtools-common/src/main/java/io/quarkus/devtools/project/buildfile/BuildFile.java#L131

    private boolean isQuarkusExtension(final ArtifactKey key) {
        if (catalog != null) {
            return findInList(catalog.getExtensions(), key).isPresent();
        }
        return isDefinedInRegistry(catalog.getExtensions(), key);
    }

return isDefinedInRegistry(catalog.getExtensions(), key); would throw NPE for catalog if it is reached
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aloubyansky aloubyansky

Labels
kind/bug Something isn't working
Projects
None yet
Milestone
2.0.0.Alpha1
Development

Successfully merging a pull request may close this issue.

Fixed a possible NPE in devtools BuildFile aloubyansky/quarkus
2 participants
@aloubyansky @rsvoboda