Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable fault-tolerance tests on JDK 16+ #17080

Closed
famod opened this issue May 7, 2021 · 2 comments · Fixed by #17328
Closed

Enable fault-tolerance tests on JDK 16+ #17080

famod opened this issue May 7, 2021 · 2 comments · Fixed by #17328
Assignees
@Ladicek
Labels
area/fault-tolerance area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/smallrye
Milestone
2.0.0.CR1

Comments

@famod
Copy link
Member

famod commented May 7, 2021 •
edited

Update to a smallrye-fault-tolerance release that incorporates smallrye/smallrye-fault-tolerance#409 (probably 5.0.1?) and revert this commit: d929049

Relates to #16195 (comment)

  • set JDK 16 (e.g. via sdk)
  • if Kotlin 1.5 is not yet integrated: add --add-opens java.base/java.util=ALL-UNNAMED to MAVEN_OPTS
  • mvn -Dquickly -T1C
  • mvn clean verify -f tcks/microprofile-fault-tolerance (should not fail)
  • mvn clean verify -f tcks/microprofile-fault-tolerance -P'!jdk16-workarounds' (should fail)
  • same with integration-tests/main (RestClientTestCase#testFaultTolerance)
@famod famod added area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/fault-tolerance labels May 7, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented May 7, 2021

/cc @Ladicek

@Ladicek Ladicek self-assigned this May 10, 2021
@Ladicek
Copy link
Contributor

Ladicek commented May 10, 2021

Thanks for filing this, I'll take care of it. Hopefully this week.

@Ladicek Ladicek mentioned this issue May 19, 2021
Merged
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ladicek Ladicek

Labels
area/fault-tolerance area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/smallrye
Projects
None yet
Milestone
2.0.0.CR1
Development

Successfully merging a pull request may close this issue.

Update to SmallRye Fault Tolerance 5.1.0 and add Vert.x integration Ladicek/quarkus
2 participants
@Ladicek @famod