Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KafkaStreams UncaughtExceptionHandler can only be set before starting the stream #18018

Closed
ozangunalp opened this issue Jun 19, 2021 · 2 comments · Fixed by #18379
Closed

KafkaStreams UncaughtExceptionHandler can only be set before starting the stream #18018

ozangunalp opened this issue Jun 19, 2021 · 2 comments · Fixed by #18379
Assignees
Labels
area/kafka area/kafka-streams good first issue Good for newcomers kind/bug Something isn't working
Milestone

Comments

@ozangunalp
Copy link
Contributor

Describe the bug

It is not possible to use KafkaStreams#setUncaughtExceptionHandler on the injected KafkaStreams instance because it is already started by the KafkaStreamsProducer managed by kafka-streams Quarkus extension.

Expected behavior

The kafka-streams extension calls setUncaughtExceptionHandler with an instance of StreamsUncaughtExceptionHandler discovered in the application the before the start, much like StateListener and StateRestoreListener

Reported by @andrerigon

@ozangunalp ozangunalp added kind/bug Something isn't working area/kafka-streams labels Jun 19, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 19, 2021

/cc @cescoffier, @gunnarmorling, @rquinio

@andrerigon
Copy link
Contributor

@ozangunalp sorry for the wait, I could only work on this today. I openned #18379 for it.

How do you recommend testing this? I notice that are no tests for the other listernes, since KafkaStreams doesn't allows inspecting the stream object after you configure it. A full blown integration test using TopologyTestDriver might work, but will add considerable complexity.

@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kafka area/kafka-streams good first issue Good for newcomers kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants