Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not produce Infinispan RemoteCacheManager if no Infinispan configuration is present #18232

Closed
ppalaga opened this issue Jun 29, 2021 · 7 comments · Fixed by #18363
Closed
Labels
area/infinispan Infinispan kind/enhancement New feature or request
Milestone

Comments

@ppalaga
Copy link
Contributor

ppalaga commented Jun 29, 2021

We depend on quarkus-infinispan-client in camel-quarkus-infinispan. Camel offers some alternative ways to configure Infinispan client, e.g. users can pass the list of hosts through the Camel route definition - see apache/camel-quarkus#2344 (comment) . If the user does not provide any quarkus.infinispan.* config in application.properties, starting the application fails, because quarkus-infinispan-client still produces an improperly configured RemoteCacheManager. Thus we'd appreciate if the producer methods in InfinispanClientProducer could please return null if no quarkus.infinispan.* config was provided by the end user.

cc @jamesnetherton

@ppalaga ppalaga added the kind/enhancement New feature or request label Jun 29, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 29, 2021

/cc @gwenneg, @karesti, @wburns

@karesti
Copy link
Member

karesti commented Jun 29, 2021

we are working now on the extension, I will create a JIRA to address this issue

@karesti
Copy link
Member

karesti commented Jun 29, 2021

https://issues.redhat.com/browse/ISPN-13137

@karesti
Copy link
Member

karesti commented Jul 2, 2021

@ppalaga would this make the trick? I also upgraded to 12.1.5.Final but it has not landed in central yet
karesti@3a65b18

@jamesnetherton
Copy link
Contributor

Peter is on PTO, but it looks ok to me.

I can try to test it with camel-quarkus when 12.1.5.Final shows up in central.

@jamesnetherton
Copy link
Contributor

I tested and it didn't quite work. The problem is in InfinispanClientProducer.initialize(). It seems properties is not null and contains some values that I assume the extension set at build time?

  • infinispan.client.hotrod.protofile.org/infinispan/protostream/message-wrapping.proto
  • infinispan.client.hotrod.marshaller
  • infinispan.client.hotrod.protofile.org/infinispan/query/remote/client/query.proto

Maybe because the camel component has this dependency.

@karesti
Copy link
Member

karesti commented Jul 8, 2021

@jamesnetherton sorry I missed this comment before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infinispan Infinispan kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants