Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datasources documentation does not contain JDBC URL reference for Oracle #19986

Closed
jsmrcka opened this issue Sep 8, 2021 · 3 comments
Closed
Labels
area/documentation area/persistence kind/bug Something isn't working triage/out-of-date This issue/PR is no longer valid or relevant

Comments

@jsmrcka
Copy link
Contributor

jsmrcka commented Sep 8, 2021

Describe the bug

In https://quarkus.io/guides/datasource#jdbc-url (https://github.com/quarkusio/quarkus/blob/main/docs/src/main/asciidoc/datasource.adoc#jdbc-url-reference), an Oracle subsection is missing. It should provide a description, an example and a link to detailed documentation.

Relevant sources:
https://docs.oracle.com/cd/E11882_01/appdev.112/e13995/oracle/jdbc/OracleDriver.html
https://docs.oracle.com/en/database/oracle/oracle-database/21/jjdbc/data-sources-and-URLs.html#GUID-C4F2CA86-0F68-400C-95DA-30171C9FB8F0

Example:

=== Oracle

`jdbc:oracle:thin:@host:port/service_name`

Example:: `jdbc:oracle:thin:@localhost:1521/test`

For further details, see the https://docs.oracle.com/en/database/oracle/oracle-database/21/jjdbc/data-sources-and-URLs.html#GUID-C4F2CA86-0F68-400C-95DA-30171C9FB8F0[official documentation].

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

GraalVM version (if different from Java)

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

@jsmrcka jsmrcka added the kind/bug Something isn't working label Sep 8, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 15, 2021

/cc @DavideD, @gavinking, @gsmet, @mswatosh, @yrodiere

@Sanne Sanne added area/user-experience Will make us lose users area/documentation and removed area/user-experience Will make us lose users labels Oct 15, 2021
@Sanne
Copy link
Member

Sanne commented Oct 15, 2021

Good point, thanks for raising the issue!

@geoand
Copy link
Contributor

geoand commented Jan 27, 2023

This seems like it's already been done

@geoand geoand closed this as completed Jan 27, 2023
Quarkus Documentation automation moved this from To do to Done Jan 27, 2023
@geoand geoand added the triage/out-of-date This issue/PR is no longer valid or relevant label Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation area/persistence kind/bug Something isn't working triage/out-of-date This issue/PR is no longer valid or relevant
Development

No branches or pull requests

3 participants