Java 17 is not reflected as source/target of generated project

[rsvoboda]

Describe the bug

Java 17 is not reflected as source/target of generated project.

In dev mode one sees warning like this 2021-10-13 22:56:53,445 WARN [io.qua.dep.dev.JavaCompilationProvider] (vert.x-worker-thread-0) system modules path not set in conjunction with -source 11, line -1 in [unknown source]

Expected behavior

Project should use 17 as the value for maven.compiler. source / target / (release?).

Actual behavior

Generated pom.xml when using Java 17 looks like this:

    <maven.compiler.source>11</maven.compiler.source>
    <maven.compiler.target>11</maven.compiler.target>

How to Reproduce?

setJdk17

mvn io.quarkus.platform:quarkus-maven-plugin:2.4.0.CR1:create -DprojectGroupId=my-groupId -DprojectArtifactId=app-generated-skeleton -DprojectVersion=1.0.0-SNAPSHOT -DpackageName=org.my.group -DquarkusRegistryClient=false -DplatformArtifactId=quarkus-bom -DplatformVersion=2.4.0.CR1
mvn -f app-generated-skeleton quarkus:dev

sed -i "" "s/RESTEasy/RESTEasy v2/" app-generated-skeleton/src/main/java/org/my/group/GreetingResource.java
curl localhost:8080/hello

check the log, you will see "WARN [io.qua.dep.dev.JavaCompilationProvider] (vert.x-worker-thread-0) system modules path not set in conjunction with -source 11, line -1 in [unknown source]"

Output of uname -a or ver

macOS BigSur

Output of java -version

Java 17

GraalVM version (if different from Java)

No response

Quarkus version or git rev

2.4.0.CR1

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

[geoand]

I can't say I understand what this issue is about. Care to explain a little further please?

[rsvoboda]

tl;dr ... when generating project with Java 17 I would expect to have maven.compiler. source / target or just maven.compiler.release set to 17.

The reproducer is probably too complicated to express just ^^^ :)

[geoand]

Gotcha, thanks.

cc @ia3andy

[ia3andy]

I think it would be pretty easy to support:
https://github.com/quarkusio/quarkus/blob/main/independent-projects/tools/devtools-common/src/main/java/io/quarkus/devtools/project/codegen/CreateProjectHelper.java#L79

• For Maven: no special change needed
• For Gradle:
  https://github.com/quarkusio/quarkus/blob/main/independent-projects/tools/base-codestarts/src/main/resources/codestarts/quarkus/buildtool/gradle/base/build-layout.include.qute#L49
• For Gradle Kotlin:
  https://github.com/quarkusio/quarkus/blob/main/independent-projects/tools/base-codestarts/src/main/resources/codestarts/quarkus/buildtool/gradle-kotlin-dsl/base/build-layout.include.qute#L53

Adding Good First Issue tag

[ia3andy]

cc @ebullient (since you are refactoring some stuff around this)

[rsvoboda]

Docker templates need to be customizable too.

[ia3andy]

Ah right!

They are currently defined here (and used in the different docker templates):
https://github.com/quarkusio/quarkus/blob/main/independent-projects/tools/base-codestarts/src/main/resources/codestarts/quarkus/tooling/dockerfiles/codestart.yml#L9

But I think we should have a {#if java.version == "..."} in the templates instead (like we do with gradle).

[ebullient]

Andy -- if you want to try this.. I'm actually not focused on any of the code this touches (mostly templates, I think?)

[netodevel]

hey guys if nobody take this issue, i would like.

[ia3andy]

@netodevel go for it :)

[netodevel]

Hi Folks, i need a tip to update the dockers templates to java 17;

@ia3andy, you gave the hint to transform /src/main/resources/codestarts/quarkus/tooling/dockerfiles/codestart.yml into a qute template;

but I didn't find it in the code where I register this template and pass values;

The progress of this issue can be seen here: #20849

[ia3andy]

@netodevel I meant you can directly use {#if java.version == "..."} there:

• https://github.com/quarkusio/quarkus/blob/main/independent-projects/tools/base-codestarts/src/main/resources/codestarts/quarkus/tooling/dockerfiles/base/src/main/docker/Dockerfile.tpl.qute.jvm#L5
• https://github.com/quarkusio/quarkus/blob/main/independent-projects/tools/base-codestarts/src/main/resources/codestarts/quarkus/tooling/dockerfiles/base/src/main/docker/Dockerfile.tpl.qute.legacy-jar#L5

[gsmet]

Fixed by #20849