Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jvmTarget for kotlin-maven-plugin set to 11 even if project is generated with Java 17 #23235

Closed
rsvoboda opened this issue Jan 27, 2022 · 4 comments · Fixed by #24734
Closed
Labels
Milestone

Comments

@rsvoboda
Copy link
Member

Describe the bug

jvmTarget for kotlin-maven-plugin set to 11 even if project is generated with Java 17

jvmTarget 11 is hardcoded in templates for Kotlin, it even has some logic for Java 8 which should be gone

git grep jvmTarget | grep base-codestarts
independent-projects/tools/base-codestarts/src/main/resources/codestarts/quarkus/buildtool/gradle-kotlin-dsl/kotlin/build.tpl.qute.gradle.kts:
    kotlinOptions.jvmTarget = JavaVersion.VERSION_11.toString()
independent-projects/tools/base-codestarts/src/main/resources/codestarts/quarkus/buildtool/gradle-kotlin-dsl/kotlin/build.tpl.qute.gradle.kts:
    kotlinOptions.jvmTarget = JavaVersion.VERSION_1_8.toString()
independent-projects/tools/base-codestarts/src/main/resources/codestarts/quarkus/buildtool/gradle/kotlin/build.tpl.qute.gradle:
    kotlinOptions.jvmTarget = JavaVersion.VERSION_11
independent-projects/tools/base-codestarts/src/main/resources/codestarts/quarkus/buildtool/gradle/kotlin/build.tpl.qute.gradle:
    kotlinOptions.jvmTarget = JavaVersion.VERSION_11
independent-projects/tools/base-codestarts/src/main/resources/codestarts/quarkus/buildtool/maven/kotlin/pom.tpl.qute.xml:
                    <jvmTarget>11</jvmTarget>

Changes similar to #20849 should be done to kontlin templates

Expected behavior

<jvmTarget>17</jvmTarget> in the config of kotlin-maven-plugin

Actual behavior

<jvmTarget>11</jvmTarget> in the config of kotlin-maven-plugin

How to Reproduce?

Output of uname -a or ver

No response

Output of java -version

Java 17

GraalVM version (if different from Java)

No response

Quarkus version or git rev

2.6.3.Final

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

@rsvoboda rsvoboda added the kind/bug Something isn't working label Jan 27, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Jan 27, 2022

/cc @evanchooly, @quarkusio/devtools @ia3andy

@Sanne
Copy link
Member

Sanne commented Jan 28, 2022

@rsvoboda why is this a problem?

@rsvoboda
Copy link
Member Author

This issue is about inconsistency, when using Java 17 I expect to have all defaults set to 17, now I have <maven.compiler.release>17</maven.compiler.release> property set, but <jvmTarget>11</jvmTarget> for kotlin-maven-plugin

@Sanne
Copy link
Member

Sanne commented Jan 31, 2022

Ok sure that makes sense, I wondered if there was a functionality problem being caused by this. Thanks for clarifying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants