Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample project with rest-client-codestart has test failures #24553

Closed
rsvoboda opened this issue Mar 25, 2022 · 5 comments · Fixed by #24551
Closed

Sample project with rest-client-codestart has test failures #24553

rsvoboda opened this issue Mar 25, 2022 · 5 comments · Fixed by #24551
Labels
area/codestarts area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/rest-client kind/bug Something isn't working
Milestone

Comments

@rsvoboda
Copy link
Member

Describe the bug

sample project with rest-client-codestart has test failures

[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.049 s <<< FAILURE! - in io.quarkus.qe.MyRemoteServiceTest
[ERROR] io.quarkus.qe.MyRemoteServiceTest.testExtensionsRestClientEndpoint  Time elapsed: 0.579 s  <<< FAILURE!
org.opentest4j.AssertionFailedError: expected: <REST Client> but was: <>
	at io.quarkus.qe.MyRemoteServiceTest.testExtensionsRestClientEndpoint(MyRemoteServiceTest.java:26)

Test fails on Assertions.assertEquals("REST Client", extension.shortName); check
https://github.com/quarkusio/quarkus/blob/main/devtools/project-core-extension-codestarts/src/main/resources/codestarts/quarkus/extension-codestarts/rest-client-codestart/java/src/test/java/org/acme/MyRemoteServiceTest.java#L26

There is no shortName defined for quarkus-rest-client extension, see https://stage.code.quarkus.io/api/extensions?id=io.quarkus:quarkus-rest-client

To resolve this either test in the codestart needs to be adjusted or metadata for code.quarkus need to be enhanced to provide shortName for quarkus-rest-client extension

cc @ia3andy / @maxandersen

Expected behavior

sample project with rest-client-codestart has no failures

Actual behavior

sample project with rest-client-codestart has test failures

How to Reproduce?

Output of uname -a or ver

macOS Monterey

Output of java -version

Java 17

GraalVM version (if different from Java)

No response

Quarkus version or git rev

2.7.5.Final

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

@rsvoboda rsvoboda added kind/bug Something isn't working area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins labels Mar 25, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Mar 25, 2022

/cc @ia3andy, @michalszynkiewicz, @quarkusio/devtools

@ia3andy
Copy link
Contributor

ia3andy commented Mar 25, 2022

Already fixed in #24551 (comment)

@ia3andy
Copy link
Contributor

ia3andy commented Mar 25, 2022

I'll keep it open until the PR is merged

@ia3andy ia3andy reopened this Mar 25, 2022
@rsvoboda
Copy link
Member Author

+1, I was wondering why are you closing the issue as duplicate with link to the PR

@ia3andy
Copy link
Contributor

ia3andy commented Mar 25, 2022

+1, I was wondering why are you closing the issue as duplicate with link to the PR

me too :)

@gsmet gsmet added this to the 2.8.0.Final milestone Mar 28, 2022
@gsmet gsmet modified the milestones: 2.8.0.Final, 2.7.6.Final May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/codestarts area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/rest-client kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants