Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI allows to create project with comma in the name #25991

Closed
rsvoboda opened this issue Jun 7, 2022 · 3 comments · Fixed by #28835
Closed

CLI allows to create project with comma in the name #25991

rsvoboda opened this issue Jun 7, 2022 · 3 comments · Fixed by #28835
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) kind/bug Something isn't working
Milestone

Comments

@rsvoboda
Copy link
Member

rsvoboda commented Jun 7, 2022

Describe the bug

CLI allows to create project with comma in the name. Comma is not allowed character for artifactId in maven projects

quarkus create app app,with,comma
cd app,with,comma
quarkus build

...

[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[ERROR] 'artifactId' with value 'app,with,comma' does not match a valid id pattern. @ line 6, column 15
 @
[ERROR] The build could not read 1 project -> [Help 1]
[ERROR]
[ERROR]   The project org.acme:app,with,comma:1.0.0-SNAPSHOT (/Users/rsvoboda/tmp/app,with,comma/pom.xml) has 1 error
[ERROR]     'artifactId' with value 'app,with,comma' does not match a valid id pattern. @ line 6, column 15

Expected behavior

CLI complains about problematic character

Actual behavior

CLI allows to create project with comma in the name. Comma is not allowed character for artifactId in maven projects

How to Reproduce?

quarkus create app app,with,comma
cd app,with,comma
quarkus build

Output of uname -a or ver

No response

Output of java -version

Java 11

GraalVM version (if different from Java)

No response

Quarkus version or git rev

2.9.2.Final

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

@rsvoboda rsvoboda added the kind/bug Something isn't working label Jun 7, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 7, 2022

/cc @ebullient, @maxandersen

@quarkus-bot quarkus-bot bot added the area/cli Related to quarkus cli (not maven/gradle/etc.) label Jun 7, 2022
@ebullient
Copy link
Contributor

what do you think is the right answer: a failure, or a fixed artifact Id?

@gsmet
Copy link
Member

gsmet commented Oct 25, 2022

We should make sure it is a valid artifactId and fail IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants