Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename misspelled property io.quarkus.oidc.deployment.DevUiConfig#webClienTimeout to webClientTimeout #26648

Closed
marcwrobel opened this issue Jul 11, 2022 · 2 comments · Fixed by #26667
Closed

Rename misspelled property io.quarkus.oidc.deployment.DevUiConfig#webClienTimeout to webClientTimeout #26648

marcwrobel opened this issue Jul 11, 2022 · 2 comments · Fixed by #26667
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/oidc
Milestone
2.11.0.CR1

Comments

@marcwrobel
Copy link
Contributor

Description

The property io.quarkus.oidc.deployment.DevUiConfig#webClienTimeout is misspelled, it should be renamed to webClientTimeout.

Implementation ideas

Similar to what has been done for io.quarkus.oidc.deployment.devservices.keycloak.DevServicesConfig#webClienTimeout, io.quarkus.oidc.deployment.DevUiConfig#webClienTimeout may be deprecated in favor of a new property : io.quarkus.oidc.deployment.DevUiConfig#webClientTimeout.

It may also be a good time to remove the deprecated property io.quarkus.oidc.deployment.devservices.keycloak.DevServicesConfig#webClienTimeout.
@marcwrobel marcwrobel added the area/housekeeping Issue type for generalized tasks not related to bugs or enhancements label Jul 11, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 11, 2022

/cc @pedroigor, @sberyozkin

@sberyozkin
Copy link
Member

Thanks @marcwrobel, I'm not sure it is worth deprecating this mistyped property as it is in the deployment only and does not affect the production code, I don't think users are really using these timeout properties, we've added them just in case

@sberyozkin sberyozkin mentioned this issue Jul 11, 2022
Merged
@quarkus-bot quarkus-bot bot added this to the 2.11 - main milestone Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/oidc
Projects
None yet
Milestone
2.11.0.CR1
Development

Successfully merging a pull request may close this issue.

Rename misspelled OIDC DevUI 'webClienTimeout' to 'webClientTimeout' sberyozkin/quarkus
2 participants
@sberyozkin @marcwrobel