quarkus-hibernate-orm entity manager merge of detached entity does not work

[waldimiro]

With quarkus-hibernate-orm extension, entityManager.merge(entity) for a detached entity in a transactional method does not work. Entity will not be updated.

[gsmet]

@waldimiro could you create a reproducer?

[waldimiro]

@gsmet I have a simple multi module scenario where:

module-1
Contains my JPA model (Entities)

module-2
Imports module-1
Exposes a REST endpoint that consumes a JSON
A service class serialize the JSON in a module-1 entity
A transactional method of service class try to merge the entity

[gsmet]

@waldimiro a simple reproducer would help. It shouldn't take you too much time.

[gsmet]

We had several reports of this. We should try to investigate.

[gsmet]

This might be related to this issue: #3127 .

[Sanne]

@dreab8 could you add a test for this?

[dreab8]

Hi @waldimiro,
I created a project https://github.com/dreab8/qurkus-merge-detached that tries to replicate the issue you described but without any luck, can you please give a look at it and tell me if I am missing anything? thanks a lot

[waldimiro]

Hi @dreab8

Thank you for your time. The differences are:

model module

-- there are no application.properties, persistence properties are declared in service.
-- All my entities inherits from AbstractEntity (with an abstract getId, setId)

service module
-- application.properties contains persistence properties (quarkus.hibernate-orm.database.generation=none)
-- TestEntityService inherits from AbstractRepository where is injected the EntityManager.
-- TestEntityService has at class level the @transactional annotation.
-- TestEntityService has at class level another interceptor @lock(LockType.READ) (the concurrency solution that you can find here https://www.knitelius.com/2016/01/25/concurrency-control-for-cdi/)
-- MergedEntityResource is @RequestScoped

[waldimiro]

mhh I ask me if it is related to #2918, please read my last comment.

[gsmet]

@waldimiro I don't think we will be able to make progress on this this way.

Could you create a simple reproducer so that we can clearly see what's going wrong. It shouldn't be too hard and it would help us a lot.

Thanks.

[gsmet]

Please open another issue with a full reproducer if you end up having one.

[Sanne]

Reopening, we crafted a reproducer in ORM. We're working on this.

[rsvoboda]

@Sanne any update on this ?

[Sanne]

It's very complex but at last week's meeting we brainstormed this. I think I know now what we should do, but will need the time to explore further.

Described as:

• https://hibernate.atlassian.net/browse/HHH-13826

[EfraimLA]

So there's not other way to merge entire entity collections?

[claud1nho]

@Sanne Even with the latest Quarkus 2.3 it is still not possible to reliably set fields back to null with em.merge() when the entity is detached. I am a little disappointed of my favorite framework that after more than one and a half year passing by, there is still no fix. In my opinion merging detached entities is not an edge case that could be ignored. Looking forward to a solution.

[guoxunbo]

any update related to this merge issue? We're facing the same issue？

[yrodiere]

FWIW this seems to relate to https://hibernate.atlassian.net/browse/HHH-17761, which was fixed in Hibernate ORM 6.5 and thus should be fixed when we upgrade to that version in Quarkus (PR incoming).