Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCKER_CONFIG #28354

Closed
derlin opened this issue Oct 3, 2022 · 1 comment · Fixed by #28355
Closed

DOCKER_CONFIG #28354

derlin opened this issue Oct 3, 2022 · 1 comment · Fixed by #28355
Labels
area/container-image kind/enhancement New feature or request
Milestone
2.13.1.Final

Comments

@derlin
Copy link
Contributor

derlin commented Oct 3, 2022

Description

Support for DOCKER_CONFIG has been added in #27460. However, in jib, the DOCKER_CONFIG should point to a directory containing a config.json, while in the quarkus implementation it must point to the config.json file itself. This is very confusing, especially since there is no documentation. I suggest to change the quarkus jib plugin to match the behaviour of jib.

Implementation ideas

I already have a PR ready for this fix.
@derlin derlin added the kind/enhancement New feature or request label Oct 3, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 3, 2022

/cc @geoand

@derlin derlin mentioned this issue Oct 3, 2022
Merged
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Oct 4, 2022
@gsmet gsmet modified the milestones: 2.14 - main, 2.13.1.Final Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/container-image kind/enhancement New feature or request
Projects
None yet
Milestone
2.13.1.Final
Development

Successfully merging a pull request may close this issue.

Honour DOCKER_CONFIG env var in jib the same way as in jib-core derlin/quarkus
2 participants
@gsmet @derlin