Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move OidcClientFilter annotation to quarkus-oidc-client #28470

Closed
sberyozkin opened this issue Oct 10, 2022 · 1 comment · Fixed by #28472
Closed

Move OidcClientFilter annotation to quarkus-oidc-client #28470

sberyozkin opened this issue Oct 10, 2022 · 1 comment · Fixed by #28472
Labels
area/oidc kind/enhancement New feature or request
Milestone
2.13.2.Final

Comments

@sberyozkin
Copy link
Member

Description

As analyzed by @rsvoboda, moving from quarkus-oidc-client-filter to quarkus-oidc-client-reactive-filter will require users changing the package name of @OidcClientFilter since each of these 2 extensions has its own @OidcClientFilter but in a different package.

It makes sense to have this annotation shared between these 2 extensions.

Implementation ideas

Move @OidcClientFilter to quarkus-oidc-client for now and revisit in the future as needed.
@sberyozkin sberyozkin added the kind/enhancement New feature or request label Oct 10, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 10, 2022

/cc @pedroigor

@sberyozkin sberyozkin mentioned this issue Oct 10, 2022
Merged
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Oct 10, 2022
@gsmet gsmet modified the milestones: 2.14 - main, 2.13.2.Final Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/oidc kind/enhancement New feature or request
Projects
None yet
Milestone
2.13.2.Final
Development

Successfully merging a pull request may close this issue.

Move OidcClientFilter annotation to quarkus-oidc-client sberyozkin/quarkus
2 participants
@sberyozkin @gsmet