Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected warning message after reload a Dev Mode application #29840

Closed
pjgg opened this issue Dec 13, 2022 · 4 comments
Closed

Unexpected warning message after reload a Dev Mode application #29840

pjgg opened this issue Dec 13, 2022 · 4 comments
Labels

Comments

@pjgg
Copy link
Contributor

pjgg commented Dec 13, 2022

Describe the bug

Quarkus 2.7.6.Final+
Is working as expected at least in the latest version: 2.14.3.Final

When end-user changes a build time property through DevUI (Quarkus devMode) unexpected warning message show up in the reloaded application. 

 Quarkus App name: code-with-quarkus to code-with-quarkus-dd

 --/ __ \/ / / / _ | / _ \/ //_/ / / / __/
 -/ /_/ / /_/ / __ |/ , _/ ,< / /_/ /\ \
--\___\_\____/_/ |_/_/|_/_/|_|\____/___/
2022-06-15 14:05:12,163 INFO  [io.quarkus] (Quarkus Main Thread) code-with-quarkus 1.0.0-SNAPSHOT on JVM (powered by Quarkus 2.9.2.Final) started in 2.704s. Listening on: http://localhost:8080

2022-06-15 14:05:12,181 INFO  [io.quarkus] (Quarkus Main Thread) Profile dev activated. Live Coding activated.
2022-06-15 14:05:12,182 INFO  [io.quarkus] (Quarkus Main Thread) Installed features: [cdi, resteasy-reactive, smallrye-context-propagation, vertx]
2022-06-15 14:05:48,628 INFO  [io.qua.dep.dev.RuntimeUpdatesProcessor] ([DevConsole]vert.x-eventloop-thread-0) File change detected: /Users/rsvoboda/Downloads/code-with-quarkus/src/main/resources/application.properties
2022-06-15 14:05:48,633 INFO  [io.qua.dep.dev.RuntimeUpdatesProcessor] ([DevConsole]vert.x-eventloop-thread-0) Restarting quarkus due to changes in application.properties.
2022-06-15 14:05:48,654 INFO  [io.quarkus] (Quarkus Main Thread) code-with-quarkus stopped in 0.020s
__  ____  __  _____   ___  __ ____  ______
 --/ __ \/ / / / _ | / _ \/ //_/ / / / __/
 -/ /_/ / /_/ / __ |/ , _/ ,< / /_/ /\ \
--\___\_\____/_/ |_/_/|_/_/|_|\____/___/
2022-06-15 14:05:48,900 WARN  [io.qua.run.con.ConfigRecorder] (Quarkus Main Thread) Build time property cannot be changed at runtime:
 - quarkus.application.name is set to 'code-with-quarkus' but it is build time fixed to 'code-with-quarkus-dd'. Did you change the property quarkus.application.name after building the application?

2022-06-15 14:05:48,904 INFO  [io.quarkus] (Quarkus Main Thread) code-with-quarkus-dd 1.0.0-SNAPSHOT on JVM (powered by Quarkus 2.9.2.Final) started in 0.241s. Listening on: http://localhost:8080
2022-06-15 14:05:48,905 INFO  [io.quarkus] (Quarkus Main Thread) Profile dev activated. Live Coding activated.
2022-06-15 14:05:48,905 INFO  [io.quarkus] (Quarkus Main Thread) Installed features: [cdi, resteasy-reactive, smallrye-context-propagation, vertx]
2022-06-15 14:05:48,906 INFO  [io.qua.dep.dev.RuntimeUpdatesProcessor] ([DevConsole]vert.x-eventloop-thread-0) Live reload total time: 0.281s
2022-06-15 14:16:10,445 INFO  [io.quarkus] (Shutdown thread) code-with-quarkus-dd stopped in 0.007s 

Unexpected warning message:

WARN [io.qua.run.con.ConfigRecorder] (Quarkus Main Thread) Build time property cannot be changed at runtime: - quarkus.application.name is set to 'code-with-quarkus' but it is build time fixed to 'code-with-quarkus-dd'. Did you change the property quarkus.application.name after building the application?  

Related to: #25512

Expected behavior

No warning message as the current upstream version

Actual behavior

No response

How to Reproduce?

mvn io.quarkus.platform:quarkus-maven-plugin:2.7.6.Final:create -DplatformVersion=2.7.6.Final\
    -DprojectGroupId=my-groupId \
    -DprojectArtifactId=my-artifactId
cd getting-started
mvn quarkus:dev 
  1. Navigated to dev UI - Config Editor and changed quarkus.application.name to code-with-quarkus-dd. This triggered application restart and complaint about the old app name
  2. You will see the following warning message in the reloaded application
WARN  [io.qua.run.con.ConfigRecorder] (Quarkus Main Thread) Build time property cannot be changed at runtime:
 - quarkus.application.name is set to 'code-with-quarkus' but it is build time fixed to 'code-with-quarkus-dd'. Did you change the property quarkus.application.name after building the application? 

Output of uname -a or ver

No response

Output of java -version

openjdk 17.0.5 2022-10-18 OpenJDK Runtime Environment Temurin-17.0.5+8 (build 17.0.5+8) OpenJDK 64-Bit Server VM Temurin-17.0.5+8 (build 17.0.5+8, mixed mode, sharing)

GraalVM version (if different from Java)

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

@pjgg pjgg added the kind/bug Something isn't working label Dec 13, 2022
@mkouba
Copy link
Contributor

mkouba commented Dec 15, 2022

CC @radcortez

@radcortez
Copy link
Member

Is working as expected at least in the latest version: 2.14.3.Final

Yes, this was fixed in #26802, available in 2.12.

I'm not sure what is the expectation. Backport it to previous versions?

@gsmet
Copy link
Member

gsmet commented Dec 15, 2022

We won't backport it to 2.7. If it's working with 2.13, I would suggest we close this one. @pjgg can you confirm 2.13 is OK?

@pjgg
Copy link
Contributor Author

pjgg commented Dec 15, 2022

Yes in working on 2.13. So I am going to close the issue~
Thanks @radcortez @gsmet

@pjgg pjgg closed this as completed Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants