Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address technical debt following integration of Hibernate Reactive 2.0.0.Alpha2 #31974

Open
Sanne opened this issue Mar 20, 2023 · 4 comments
Open
Labels
area/hibernate-reactive area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/persistence

Comments

@Sanne
Copy link
Member

Sanne commented Mar 20, 2023

Description

For sake of iterarive development and re-enabling CI monitoring on the Hibernate Reactive modules, we're merging pr #31454 with some pending tasks still open:

  • Need to investigate test which was disabled in f6584a1 ( See comments in extensions/panache/hibernate-reactive-rest-data-panache/deployment/src/test/java/io/quarkus/hibernate/reactive/rest/data/panache/deployment/openapi/OpenApiIntegrationTest.java)
  • @yrodiere applied some improvements on the Hibernate ORM (blocking) extension to enhanced the Dialect selection, in particular configured versions. We might want to follow up and align the HR extension to this.
  • Ideally not ship with an Alpha release? Or flag the extension appropriately as early preview.
  • Migration guide work?

Implementation ideas

No response

@Sanne Sanne added area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/hibernate-reactive labels Mar 20, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Mar 20, 2023

/cc @DavideD (hibernate-reactive), @gavinking (hibernate-reactive)

@yrodiere
Copy link
Member

yrodiere commented Mar 20, 2023

Looks like #31947 (configurable default optimizer, defaulting to pooled-lo) would need to be ported to Reactive as well

@yrodiere
Copy link
Member

Looks like #31947 (configurable default optimizer, defaulting to pooled-lo) would need to be ported to Reactive as well

This particular issue is being addressed in #32044, but the rest isn't.

@Sanne
Copy link
Member Author

Sanne commented Mar 23, 2023

Adding: we should add the integration tests provided in #32040 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/hibernate-reactive area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/persistence
Projects
None yet
Development

No branches or pull requests

2 participants