Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AccessTokenRequestReactiveFilter::propagateToken duplicates the authorization header #36810

Closed
sahuefficy opened this issue Nov 1, 2023 · 4 comments · Fixed by #36835
Closed

Comments

@sahuefficy
Copy link
Contributor

requestContext.getHeaders().add(HttpHeaders.AUTHORIZATION, BEARER_SCHEME_WITH_SPACE + accessToken);
duplicates the authorization header with bearer scheme in case a re-attempt is made to an end point within the same same request handling paradigm.

I faced that while implementing retry for a RestClient.

I will send a PR shortly.

@sberyozkin
Copy link
Member

@sahuefficy thanks, can you please also check if the header should be set instead of being added in the non reactive version

@sahuefficy
Copy link
Contributor Author

Did you refer to the following:

requestContext.getHeaders().add(HttpHeaders.AUTHORIZATION, BEARER_SCHEME_WITH_SPACE + token);

I can see the same pattern there too.

@sahuefficy
Copy link
Contributor Author

sahuefficy commented Nov 1, 2023

This has been in all versions. I am using 2.16 though.

@quarkus-bot
Copy link

quarkus-bot bot commented Nov 1, 2023

/cc @pedroigor (bearer-token)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants