Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using @ Transaction in @ Observes print warning log: WARN [io.agr.pool] (trans-consumer-4) Datasource '<default>': Closing open connection prior to commit #36877

Closed
Clever-Wang opened this issue Nov 5, 2023 · 5 comments
Labels
area/agroal kind/bug Something isn't working triage/duplicate This issue or pull request already exists

Comments

@Clever-Wang
Copy link

Describe the bug

Quarkus version : 3.5.0

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

@Clever-Wang Clever-Wang added the kind/bug Something isn't working label Nov 5, 2023
@yrodiere
Copy link
Member

yrodiere commented Nov 6, 2023

Thank you but I think I'll need a little bit more information, like the extensions you're using.

Please provide a simple project (as a zip, github repo, ...) that reproduces the problem?

@yrodiere yrodiere added triage/needs-reproducer We are waiting for a reproducer. area/agroal labels Nov 6, 2023
@mmusgrov
Copy link
Contributor

This problem looks like a duplicate of #18737

I have a fix for it (#34160 ) but it fails one of the panache tests and I haven't had a chance to fully investigate why the test fails ... but let me take another look at the failing test and I will update this thread when I've figured it out.

The java stacktrace for the successful case is https://pastebin.com/Lk9UpUGv and for the unsuccessful case it is https://pastebin.com/rVUUSFAy

@mmusgrov
Copy link
Contributor

I found the issue with the PR, I wasn't re-throwing the exception during the before synchronization handler. I've updated my PR on the other issue with the fix so let's see how it does this time ...

@mmusgrov
Copy link
Contributor

Actually although throwing the exception fixes the failing test it will stop any subsequent beforeCompletion synchronizations from running so we will need a different strategy, or maybe the test is wrong - I will investigate further.

@yrodiere
Copy link
Member

This problem looks like a duplicate of #18737

Alright, closing as duplicate of #18737 then.

@Clever-Wang feel free to chime in if you think this is a different problem, otherwise let's continue the conversation on #18737.

@yrodiere yrodiere closed this as not planned Won't fix, can't repro, duplicate, stale Nov 13, 2023
@yrodiere yrodiere added triage/duplicate This issue or pull request already exists and removed triage/needs-reproducer We are waiting for a reproducer. labels Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/agroal kind/bug Something isn't working triage/duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants