Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra INFO log in Hibernate ORM HHH10005004: Stopping BeanContainer : %s #37735

Closed
yrodiere opened this issue Dec 14, 2023 · 6 comments · Fixed by #40102
Closed

Extra INFO log in Hibernate ORM HHH10005004: Stopping BeanContainer : %s #37735

yrodiere opened this issue Dec 14, 2023 · 6 comments · Fixed by #40102
Labels
area/hibernate-orm Hibernate ORM area/persistence kind/bug Something isn't working triage/upstream Used for issues which are caused by issues in upstream projects/dependency
Milestone

Comments

@yrodiere
Copy link
Member

Describe the bug

This log appears at least in some cases when stopping the application (in my case when config validation fails on native startup):

Dec 14, 2023 11:34:05 AM org.hibernate.resource.beans.container.spi.AbstractCdiBeanContainer stop
INFO: HHH10005004: Stopping BeanContainer : %s

It's pointless, and badly formatted. We should drop it, or at least make it a DEBUG log.

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

I guess this happens with just about any app using Hibernate ORM, but here's where I noticed it: https://github.com/yrodiere/quarkus-playground/tree/i36376
Just change the Quarkus version to 999-SNAPSHOT and run mvn clean verify -Dnative.

Output of uname -a or ver

No response

Output of java -version

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

@yrodiere yrodiere added the kind/bug Something isn't working label Dec 14, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Dec 14, 2023

/cc @Sanne (hibernate-orm), @gsmet (hibernate-orm)

@gsmet
Copy link
Member

gsmet commented Dec 14, 2023

Probably a good idea to add it to the filter list here: HibernateLogFilterBuildStep.

@Sanne
Copy link
Member

Sanne commented Jan 19, 2024

I'll add it to the filter and fix in ORM

@Sanne
Copy link
Member

Sanne commented Jan 19, 2024

Actually, it's already in the filters since a couple of years, odd:

Might not be as trivial as I thought :) Anyway, fixed ORM upstream.

@yrodiere
Copy link
Member Author

Maybe LogCleanupFilterBuildItem applies to a sepecific logger, not all loggers with the given prefix?

Anyway... thanks Sanne. This should be fixed in Quarkus when https://hibernate.atlassian.net/browse/HHH-17659 gets fixed, which I think should be in Hibernate ORM 6.4.3.

@yrodiere yrodiere added the triage/upstream Used for issues which are caused by issues in upstream projects/dependency label Mar 6, 2024
@yrodiere
Copy link
Member Author

yrodiere commented Mar 6, 2024

Anyway... thanks Sanne. This should be fixed in Quarkus when https://hibernate.atlassian.net/browse/HHH-17659 gets fixed, which I think should be in Hibernate ORM 6.4.3.

Update: this is going into ORM 6.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/hibernate-orm Hibernate ORM area/persistence kind/bug Something isn't working triage/upstream Used for issues which are caused by issues in upstream projects/dependency
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants