Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add details about relocations into README and/or CONTRIBUTING #38274

Closed
rsvoboda opened this issue Jan 18, 2024 · 7 comments · Fixed by #38341
Closed

Add details about relocations into README and/or CONTRIBUTING #38274

rsvoboda opened this issue Jan 18, 2024 · 7 comments · Fixed by #38341
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements
Milestone

Comments

@rsvoboda
Copy link
Member

Description

I don't see in Quarkus README or CONTRIBUTING documents any suggestion to use relocations profile.

This can be handy for people working with Quarkus main. Especially after #38190 change and with the upcoming https://github.com/quarkusio/quarkus/blob/main/adr/0002-reactive-rename.adoc changes.

CI is building Quarkus main with relocations:

CC @gsmet @geoand

Implementation ideas

No response

@rsvoboda rsvoboda added the area/housekeeping Issue type for generalized tasks not related to bugs or enhancements label Jan 18, 2024
@geoand
Copy link
Contributor

geoand commented Jan 18, 2024

I am not exactly sure what you would like to have documented around this. Who do you envision will be helped by such documentation and how?

@rsvoboda
Copy link
Member Author

Building with relocations section in https://github.com/quarkusio/quarkus/blob/main/CONTRIBUTING.md#workflow-tips

@maxandersen
Copy link
Contributor

same question as @geoand - not following what the usecase is? isn't that profile not only to use when publishing - and not needed elsewhere?

@rsvoboda
Copy link
Member Author

I created #38341 to show my idea.

This is the main trigger: quarkus-qe/quarkus-test-suite#1617 (comment)
We are working on test development in main branch of qe test-suite and we backport bulks to 3.2 / 2.13 branch.
Thus we want to keep main branch compatible with 3.2 as much as possible (at least till 3.8 is out).

@maxandersen
Copy link
Contributor

had a quick chat with @gsmet and the reason we do not enable by default is to make sure its noticed by extension writers or users that the artifact names are changing. If we enable by default these issues would not be noticed until its too late.

Those (like QE) that want to maintain a build that works on both branches should enable the -Drelocation knowing that its fine to do so but they might at least from time to time test withuot relocations to detect possible issues.

@michalvavrik
Copy link
Contributor

Makes sense, thanks for the context.

@rsvoboda
Copy link
Member Author

@maxandersen ok, so it's intentionally hidden and this should be closed (together with my PR)?

@quarkus-bot quarkus-bot bot added this to the 3.9 - main milestone Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants