Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid warnings about SQL Server version "0.0.0" on startup #39395

Closed
yrodiere opened this issue Mar 13, 2024 · 3 comments · Fixed by #39524
Closed

Invalid warnings about SQL Server version "0.0.0" on startup #39395

yrodiere opened this issue Mar 13, 2024 · 3 comments · Fixed by #39524
Assignees
Labels
area/persistence kind/bug Something isn't working
Milestone

Comments

@yrodiere
Copy link
Member

Describe the bug

In certain circumstances, Hibernate ORM issues a warning about an unsupported SQL Server version "0.0.0"

Expected behavior

No warning when using quarkus.datasource.db-version=14 with Quarkus 3.8.

Actual behavior

A weird warning when using quarkus.datasource.db-version=14 with Quarkus 3.8:

2024-03-13 11:43:03,217 WARN [org.hib.dia.Dialect] (Quarkus Main Thread) HHH000511: The 0.0.0 version for [org.hibernate.dialect.SQLServerDialect] is no longer supported, hence certain features may not work properly. The minimum supported version is 11.0.0. Check the community dialects project for available legacy versions.

Note the warning comes from Hibernate ORM, not from Quarkus.

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

See https://quarkusio.zulipchat.com/#narrow/stream/187030-users/topic/Compatibility.20mode.20for.20hibernate/near/426307824

Note the warning comes from Hibernate ORM, not from Quarkus.

@yrodiere yrodiere added the kind/bug Something isn't working label Mar 13, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented Mar 13, 2024

You added a link to a Zulip discussion, please make sure the description of the issue is comprehensive and doesn't require accessing Zulip

This message is automatically generated by a bot.

@yrodiere
Copy link
Member Author

It would seem the problem happens when the db-version includes a leading or trailing whitespace:

more bad: i had a white space after 0 ..... thats why the warning pops up :)

So, we just need to trim the db-version at some point before parsing it.

@quarkus-bot
Copy link

quarkus-bot bot commented Mar 13, 2024

/cc @DavideD (hibernate-reactive), @gavinking (hibernate-reactive), @gsmet (hibernate-orm), @mswatosh (db2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/persistence kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants