Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarkus OpenTelemetry Rest Client Span Name with Route (URL Path Template) #39457

Closed
luneo7 opened this issue Mar 14, 2024 · 4 comments · Fixed by #39534
Closed

Quarkus OpenTelemetry Rest Client Span Name with Route (URL Path Template) #39457

luneo7 opened this issue Mar 14, 2024 · 4 comments · Fixed by #39534
Assignees
Milestone

Comments

@luneo7
Copy link
Contributor

luneo7 commented Mar 14, 2024

Description

I've read the OTEL spec and there it says that HTTP client span names SHOULD be {method}...
But it also says that:

Instrumentation MUST NOT default to using URI path as span name, but MAY provide hooks to allow custom logic to override the default span name.

A while back we already had Common URL Template path handling for client REST requests (https://github.com/quarkusio/quarkus/pull/17676/files#diff-7ec5f78d8d81fbcc3f6ddfbbaebd02aabf6bf0a843693411d955bdeba8a1d74eR56)... So can we maybe add a config parameter to change the behavior to the old way of creating rest client span names?

Having the name as {method} {urlPathTemplate} helps a lot while browsing the spans through the traces UI...

As right now everything (all rest clients in a app) are grouped as the HTTP methods (GET, POST, PUT....)

Implementation ideas

No response

@quarkus-bot
Copy link

quarkus-bot bot commented Mar 14, 2024

/cc @brunobat (opentelemetry), @cescoffier (rest-client), @geoand (rest-client), @radcortez (opentelemetry)

@brunobat
Copy link
Contributor

This was fixed on the server but not in the client...

@luneo7
Copy link
Contributor Author

luneo7 commented Mar 15, 2024

Oh, so it wasn't on purpose that it was removed? If that is the case I can tackle this if you would like 😁

@brunobat
Copy link
Contributor

Please do @luneo7 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants