Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receive files outside the classpath in quarkus-liquibase-mongodb #39683

Closed
juanjogv opened this issue Mar 25, 2024 · 1 comment · Fixed by #39680
Closed

Receive files outside the classpath in quarkus-liquibase-mongodb #39683

juanjogv opened this issue Mar 25, 2024 · 1 comment · Fixed by #39680

Comments

@juanjogv
Copy link
Contributor

juanjogv commented Mar 25, 2024

Description

Due to the nature in which the resourceAccessor was created and injected when instantiating the Liquibase class
in LiquibaseMongodbFactory.createLiquibase()

try (ClassLoaderResourceAccessor resourceAccessor = new ClassLoaderResourceAccessor(Thread.currentThread().getContextClassLoader()))

it was not possible to pass a changeLog outside the classpath via liquibase-mongodb.change-log property. For people like me who want to use the quarkus-liquibase-mongodb extension only with the dev and test profiles in conjunction with the devservices and in productive environments use the liquibase cli directly this implementation is a bit problematic.

I also took the opportunity to implement the search-path property described in: docs.liquibase which allows me to limit the scope of the DirectoryResourceAccessor and not give it the default value of DirectoryResourceAccessor(Paths.get("/")).

Implementation ideas

Alredy implemented in the following PR

@quarkus-bot
Copy link

quarkus-bot bot commented Mar 25, 2024

/cc @andrejpetras (liquibase), @geoand (liquibase), @gsmet (liquibase), @loicmathieu (mongodb)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant