Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live coding feature not working when shutdown timeout is configured #40398

Open
ghost opened this issue May 1, 2024 · 3 comments
Open

Live coding feature not working when shutdown timeout is configured #40398

ghost opened this issue May 1, 2024 · 3 comments
Labels
area/core area/kotlin kind/bug Something isn't working triage/consider-closing Bugs that are considered to be closed because too old. Using the label to do a mark and sweep proces

Comments

@ghost
Copy link

ghost commented May 1, 2024

Describe the bug

Currently, there seems to be an issue with the live coding feature when shutdown.timeout is configured. The live coding feature, which is supposed to automatically reload changes made to source files during development, ceases to function properly under these circumstances.

Expected behavior

The live coding feature should continue to function as expected, automatically detecting and applying changes to source files, only when dev mode is used, regardless of whether a shutdown timeout is configured or not.

Actual behavior

Live coding feature takes a lot of time to reload when changes are detected, requiring a manual restart of the application to reflect the changes most of the times.

How to Reproduce?

Set up a Quarkus application with any of these stacks:

  • SmarllRye GraphQL
  • REST
  • REST Qute

Use the following YAML configuration file:

quarkus:
  banner:
    enabled: false
  console:
    color: false
  http:
    enable-compression: true
  log:
    category:
      "io.quarkus":
        level: INFO
    console:
      async: true
      enable: true
    level: WARN
  qute:
    suffixes: html
  shutdown: # As soon as this is removed, it works fine
    timeout: 90 # second(s)
---
"%dev":
  quarkus:
    banner:
      enabled: true
    console:
      color: true
---
"%prod":
  quarkus:
---
"%test":
  quarkus:

Output of uname -a or ver

Linux continental 6.6.28-1-lts #1 SMP PREEMPT_DYNAMIC Wed, 17 Apr 2024 10:11:09 +0000 x86_64 GNU/Linux

Output of java -version

OpenJDK 64-Bit Server VM Temurin-21.0.3+9 (build 21.0.3+9-LTS, mixed mode, sharing)

Quarkus version or git rev

3.9.3

Build tool (ie. output of mvnw --version or gradlew --version)

------------------------------------------------------------
Gradle 8.7
------------------------------------------------------------

Build time:   2024-03-22 15:52:46 UTC
Revision:     650af14d7653aa949fce5e886e685efc9cf97c10

Kotlin:       1.9.22
Groovy:       3.0.17
Ant:          Apache Ant(TM) version 1.10.13 compiled on January 4 2023
JVM:          21.0.3 (Eclipse Adoptium 21.0.3+9-LTS)
OS:           Linux 6.6.28-1-lts amd64

Additional information

No response

@ghost ghost added the kind/bug Something isn't working label May 1, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented May 1, 2024

/cc @geoand (kotlin), @radcortez (config)

@geoand
Copy link
Contributor

geoand commented May 3, 2024

As a workaround I would suggest using the prod profile for setting the property

@geoand
Copy link
Contributor

geoand commented May 3, 2024

I am actually leaning on closing this as won't fix, because if we do disregard this in dev-mode, there will no way for people to actually see it's effect unless using the production mode of the application.

@geoand geoand added the triage/consider-closing Bugs that are considered to be closed because too old. Using the label to do a mark and sweep proces label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core area/kotlin kind/bug Something isn't working triage/consider-closing Bugs that are considered to be closed because too old. Using the label to do a mark and sweep proces
Projects
None yet
Development

No branches or pull requests

2 participants