3343: add multi mongo db support

[dufoli]

fix #3343

GOAL:

quarkus.mongodb.cluster1.connection-string = mongodb://mongo1:27017,mongo2:27017
quarkus.mongodb.cluster2.connection-string = mongodb://mongo1:27017,mongo2:27017

And then use annotations above the instances of MongoClient to indicate which instance we are going to use (example imaginary @connection annotation used):

@Connection("cluster1")
@Inject
ReactiveMongoClient mongoClientCluster1

I reuse(copy) a lot of code from agroal extention to have same structure. when I do not set codecs, it work well but codec test is failing. I need help to understand how to load codec during runtime and not deployment.

previous code: load mongoClient during runtime build step
new code: create producer for each named connection (like agroal extention) and buildstep during compile time.

depend of #5387. Have to wait that it land on master

[geoand]

Seems like some of the tests are failing.

@dufoli would you like to give some details about this PR?

[dufoli]

@geoand I have fixed tests and many tests succeed!:

• BasicInteractionTest
• ListDatabaseTest
• DatabaseRunCommandTest
• DatabaseListTest
• ReactiveMongoClientTest
• ConnectionToReplicaSetTest

but a test is still failing: CollectionManagementTest
And I still need to build a unit test for multi connection.

I need help for the remaining test. IT fail with a timeout and before a really strange error on mongo side:[mongod output] : Permission denied Raw: [1570959216:414890][8624:140705864506960], file:WiredTiger.wt, WT_SESSION.checkpoint: __win_fs_rename, 105: C:\Users\olivier\Desktop\src\quarkus\extensions\mongodb-client\runtime\target\embedmongo-db-36eaa512-0929-4ce8-a36b-913061e2e295\WiredTiger.turtle.set to C:\Users\olivier\Desktop\src\quarkus\extensions\mongodb-client\runtime\target\embedmongo-db-36eaa512-0929-4ce8-a36b-913061e2e295\WiredTiger.turtle: file-rename: MoveFileExW: Acc▒s refus▒. [mongod output] : Permission denied [mongod output] 2019-10-13T11:33:36.419+0200 E STORAGE [WTCheckpointThread] WiredTiger error (13) [1570959216:418879][8624:140705864506960], file:WiredTiger.wt, WT_SESSION.checkpoint: __wt_turtle_update, 397: WiredTiger.turtle: fatal turtle file update error: Permission denied Raw: [1570959216:418879][8624:140705864506960], file:WiredTiger.wt, WT_SESSION.checkpoint: __wt_turtle_update, 397: WiredTiger.turtle: fatal turtle file update error: Permission denied [mongod output] 2019-10-13T11:33:36.420+0200 E STORAGE [WTCheckpointThread] WiredTiger error (-31804) [1570959216:419876][8624:140705864506960], file:WiredTiger.wt, WT_SESSION.checkpoint: __wt_panic, 523: the process must exit and restart: WT_PANIC: WiredTiger library panic Raw: [1570959216:419876][8624:140705864506960], file:WiredTiger.wt, WT_SESSION.checkpoint: __wt_panic, 523: the process must exit and restart: WT_PANIC: WiredTiger library panic

[dufoli]

I need review and help to format. Because it seems to be ok but failing on code format....

[geoand]

Please run ./mvnw process-resources -f extensions/mongodb-client/pom.xml and once that's done commit the changes the formatter makes.

[Dufgui]

Yo bro. I like to see you code in Java ;)

[dufoli]

good news, I have fixed the issue with codec. The mongodb test is succeed now but I have impact on panache over mongo. So I have to deep dive on it.

[geoand]

Good to hear!

[Dufgui]

For the panache case. I think you can get the default connection for a first shoot. And create an issue to treate it in a separate way.
I think the connection annotation must be put on the repository too. To get the good client in mongoOperation.

[geoand]

@loicmathieu since you have plenty of Mongo experience, would you like to check the PR out and let us know what you think?

[loicmathieu]

I check globally the PR and ask some changes.
I don't check all the mongo connection initialization code, I hope you copy/paste it from the existing one :)

I can help for the Mongodb With Panache part if you didn't succeed to make it works.
After this PR is merged, we should update Mongodb With Panache to support multiple MongoClient, you can open an issue for this afterwards I'll take care of it.

[gsmet]

Just to be sure this gets properly squashed before merging. Please dismiss once everything is squashed properly.

Thanks!

[dufoli]

@geoand ping ;-) test has finished to run and now I get an error that I have not before my push. It do not succeed to get the producer to set up the config. I think it is because unremovable annotation make it failed to be created. I do not know why. producer is created in mongoClientProcessor. inside function createMongoClientProducerBean

[dufoli]

I have test many way to generated bean unremovable.... but still failing.
my test was

1. put annotation unremovable on producer class thanks to class cotrusctor FAILED
2. create a build step with GeneratedBeanBuildItem as param and AdditionalBeanBuildItem. unremovalOf(getMongoClientProducerClassName()) ==> MongoClientProducer can not been found
3. add it inside recorder with a callback function in created function ==> failed too
4. add it right at the end of createMongoClientProducerBean ==> failed again
5. change build return from beanContainerListeners to void and add a BuildProducer beanContainerListeners in order to additionalBeans.produce after beanContainerListeners.produce ==> failed.

IT was my last attempt... I still do not understand order of call and how be sure that generatedBean is produce and loaded before make it unremovable (and on the right side (deployment and not runtime).

[loicmathieu]

@dufoli I'll checkout your branch today and have a look.
Maybe @cescoffier that implements the mongo-client extension can also have a look, maybe he will find the issue.

To debug if it's really a bean removal you can:

• De-activate the removal of beans in the IT
• Put Quarkus logs on DEBUG to see what happens on Arc

[geoand]

@dufoli have you looked at the output of the generated producer (it would be found under target/wiring-classes in a project that uses this extension) to see if there might be something obviously wrong with the produced code?

[loicmathieu]

@geoand the extension development guide says that classes are generated into memory during augmentation, and that a java property needs to be specified to have them outputed into a directory: https://quarkus.io/guides/extension-authors-guide#troubleshooting-debugging-tips

[geoand]

@dufoli although not ideal, you could replace

AbstractMongoClientProducer producer = Arc.container().instance(AbstractMongoClientProducer.class).get();

with

Arc.container().instance(Class.forName("io.quarkus.mongodb.runtime.MongoClientProducer"));

and things will work (I tested).

I would suggest however extracting the common things into a MongoClientProducer interface, have the AbstractMongoClientProducer implement that interface and of course have MongoClientProducerImpl implement that abstract class (like you are doing now).

In that case, you'll (most likely) be able to pull the bean out of Arc using MongoClientProducer producer = Arc.container().instance(MongoClientProducer.class).get();

Does that make sense?

[geoand]

@geoand the extension development guide says that classes are generated into memory during augmentation, and that a java property needs to be specified to have them outputed into a directory: https://quarkus.io/guides/extension-authors-guide#troubleshooting-debugging-tips

@loicmathieu I am talking about doing the following:

mvn clean package -DskipTests -Dquarkus.build.skip=false inside the mongodb-client extension directory.
If you do that, you can see the produced bytecode in the target/wiring-classes directory. I have found it to be the easiest way to see the outcome of the bytecode I generate.

[geoand]

Also @loicmathieu TBH, the guide seems incorrect. That property is useful for dev-mode not for a typical mvn clean install. Would you be interested in verifying and providing a PR to update the guide?

[loicmathieu]

@geoand yes, I'm interesting on improving the guide. You can open an issue and assign it to me.
I already have some guide improvements tasks on my todo list so it'll be easy to works on all of them in the same time.

[geoand]

@loicmathieu Thanks! Here you go: #4635

[dufoli]

@loicmathieu @geoand I have fixed the unremovable issue. Indeed I reuse the previous code with UnremovableBeanBuildItem because annotation unremovable are not parsed for generated code. And using other code do not work either. Anyway, I am now stuck on the

[dufoli]

@geoand done!

[geoand]

Thank you!

We are having trouble with CI at the moment so it might be a while until we can get this in.

[dufoli]

@gsmet @cescoffier @geoand Hello, code is ready. I have just rebase. Can you merge it ?

[geoand]

@dufoli Thanks. I need to take another look at this before merging. I'll let you know soon enough.

[dufoli]

I have just fixed the test. It was because quarkus test is more strict now with java archive class to declared.
So I have added MongoTestBase to it.

[geoand]

@dufoli this may have been brought up before, but was is the reason that the a bunch of tests have moved?

the commits have been properly squashed

[geoand]

I think that once the testing question I have has been addressed we can merge this

[dufoli]

@geoand to be honnest, I do not remember... I can try to move it back to runtime part and check why. I think it was during a process of fixing. Not sure it was the root cause. AFAIK, I just do it because most of other extentions have it in deployment.

[geoand]

@dufoli please check and let me know. If we clear that up, I think we can merge this

[dufoli]

@geoand I have retry to switch test folder back to runtime and update pom.cxml to reflect the change and I get these errors:
Caused by: javax.enterprise.inject.UnsatisfiedResolutionException: No bean found for required type [class io.quarkus.mongodb.NamedReactiveMongoClientConfigTest] and qualifiers [[]]
at io.quarkus.arc.impl.InstanceImpl.bean(InstanceImpl.java:151)

2020-02-05 22:44:15,939 WARN [io.qua.config] (main) Unrecognized configuration key "quarkus.mongodb.cluster1.connection-string" was provided; it will be ignored
2020-02-05 22:44:15,939 WARN [io.qua.config] (main) Unrecognized configuration key "quarkus.mongodb.cluster2.connection-string" was provided; it will be ignored

[dufoli]

So I guess, it was done on purpose. I do not remember sadly the exact reason... It take too long time to review/merge sorry.

[geoand]

OK, let's merge this!

Thanks a lot for your hard work and patience @dufoli .
@loicmathieu I assume you have to rebase one of your PRs after this is in?