Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer a way to control the list of locale embedded in GraalVM native image #5244

Closed
emmanuelbernard opened this issue Nov 6, 2019 · 9 comments
Labels
area/build kind/enhancement New feature or request

Comments

@emmanuelbernard
Copy link
Member

emmanuelbernard commented Nov 6, 2019

I don't think we offer a facility to describe the list of locale a user wants in his native image. Something likequarkus.native.locale=en_EN,fr-FR driving native-image would be useful.

CC @dmlloyd @stuartwdouglas

@gsmet
Copy link
Member

gsmet commented Nov 6, 2019

I'm a big +1 on this one as it's a major issue.

But AFAIK, there's no options for that in GraalVM for now.

@Sanne
Copy link
Member

Sanne commented Nov 7, 2019

See also #5269 : timezones

@zbendhiba
Copy link
Contributor

Is there's a chance we can have this feature someday soon ?

@ppalaga
Copy link
Contributor

ppalaga commented Mar 29, 2021

Blocked by oracle/graal#2908

@ppalaga
Copy link
Contributor

ppalaga commented Apr 20, 2021

Citing from https://medium.com/graalvm/graalvm-21-1-96e18f6806b :

GraalVM 21.1 adds support for multiple locales in Native Image. Now you can specify at build time which locales should be included in the generated executable. For example, to switch the default locale to German and also include French and English, use -H:DefaultLocale=de -H:IncludeLocales=fr,en. All locales can be included via -H:+IncludeAllLocales. ResourceBundles are included by default for all selected locales, but this can be changed by providing a locale-specific substring when requesting the bundle.

It would be nice if Quarkus had config options for end users and BuildItems for extension authors to leverage the new options of the native compiler.

@maxandersen
Copy link
Contributor

related to oracle/graal#8295

@maxandersen
Copy link
Contributor

@Karm is #36876 solving this ? and any comment on how it would be affected by oracle/graal#8295

@Karm
Copy link
Member

Karm commented Feb 12, 2024

@maxandersen Yes, #37106 fixed that.

Ad oracle/graal#8295

I will take a look. I am kind of surprised this is an issue though. It seemed solved. You include what you need and move on.

@Karm Karm closed this as completed Feb 12, 2024
@Karm
Copy link
Member

Karm commented Feb 12, 2024

This is an old issue. Fixed by:
Initial support added in 2022:
#23518
Broadened to include all locales if needed in 2023:
#37106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants