Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version check of graalvm / javavm's into build tasks #6008

Closed
maxandersen opened this issue Dec 7, 2019 · 3 comments
Closed

Add version check of graalvm / javavm's into build tasks #6008

maxandersen opened this issue Dec 7, 2019 · 3 comments
Labels
kind/enhancement New feature or request
Milestone

Comments

@maxandersen
Copy link
Contributor

Description
With all the funky version combinations we are ending up with using bleeding edge graalvm it would be useful if we would at least print a warning if users are using a graalvm / javavm's version combinatons that is not the recommended one.

Implementation ideas
like current master should warn if you use graalvm < 19.3; and jdk target > 8.

@maxandersen maxandersen added the kind/enhancement New feature or request label Dec 7, 2019
@geoand
Copy link
Contributor

geoand commented Dec 7, 2019

It does fail if the GraalVM version is not the anticipared one and I recall seeing the error recently.
What scenario did you encounter were the failure wasn't being displayed?

For jdk target > 8 indeed I don't think there is a message but some unhelpful failure

@gsmet
Copy link
Member

gsmet commented Dec 7, 2019

For the record, it didn't fail if you were using a plain JDK to build and GraalVM only to build the native image.

I fixed that a few days ago in master: #5972 .

@maxandersen
Copy link
Contributor Author

ah - so its fixed in master already ? then closing this down :)

@gsmet gsmet added this to the 1.1.0 milestone Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants