Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraalVM issues to track for 1.2 / 19.3 #6222

Closed
4 of 8 tasks
gsmet opened this issue Dec 17, 2019 · 6 comments
Closed
4 of 8 tasks

GraalVM issues to track for 1.2 / 19.3 #6222

gsmet opened this issue Dec 17, 2019 · 6 comments
Labels
kind/epic Large issue with links to sub-issues triage/out-of-date This issue/PR is no longer valid or relevant

Comments

@gsmet
Copy link
Member

gsmet commented Dec 17, 2019

@gsmet gsmet added the kind/epic Large issue with links to sub-issues label Dec 17, 2019
@gsmet
Copy link
Member Author

gsmet commented Dec 17, 2019

/cc @gwenneg

@thomaswue
Copy link

Issues oracle/graal#1995 and oracle/graal#1927 are mentioned as fixed in 19.3.0.2 release notes. Other issues seem closed except for oracle/graal#1984 (where a JDK backport fix into 8u is proposed by @adinn). Let us know if there are other issues to consider or issues to reopen @emmanuelbernard.

@machi1990
Copy link
Member

Issues oracle/graal#1995 and oracle/graal#1927 are mentioned as fixed in 19.3.0.2 release notes.

I have opened a draft PR #6364 to update the Graal version and add neo4j IT tests in CI.
/cc @gsmet @gwenneg @michael-simons

@emmanuelbernard
Copy link
Member

Thanks @thomaswue Looking at oracle/graal#1984, I see the following actions:

  • @johnaohara to double check the JDK 11 memory usage. In his tests, JDK 11 was having a similar "extra" memory usage as JDK 8 which does not match the reading of the code and proposed backport of the patch from 11 to 8.
    • if the extra memory for JDK 11 is confirmed, then we are back to square 1 having to find a short term solution for SubstrateVM
  • @adinn do you know when the JDK 8 backport would be in? 8u242 or 8u252? Considering https://wiki.openjdk.java.net/display/jdk8u/Main dates and that I don't see the patch on http://hg.openjdk.java.net/jdk8u/jdk8u/ I imagine it to be more 8u252 which puts it as GA April 15th

I see the following branches for our future

  • a. JDK 11 is reasonable in memory usage and we baseline Quarkus on 11 dropping Java 8 support. Quarkus 1.2 adopts GraalVM 19.3.
  • b. JDK 11 is reasonable in memory usage, we recommend people to use Graal 19.3 for JDK 11 and 19.2 for JDK 8. AFAIK, this is not trivial and might not be possible because of some graalvm package name changes that happened between 19.2 and 19.3 CC @gsmet @gwenneg. Quarkus 1.2 adopts GraalVM 19.3.
  • c. Quarkus does not drop JDK 8 support and the double support of GraalVM 19.2/19.3 is not possible => Quarkus waits for April 15th+ to upgrade to GraalVM 19.3
  • d. JDK 11 shows the same > 20MB memory usage for the CRUD app. Quarkus waits for a solution on GraalVM 19.3+ to reach back 20MB memory usage for the CRUD app.

Am I missing a future?
@n1hility do you see any alternative?

@adinn
Copy link

adinn commented Jan 2, 2020

@emmanuelbernard jdk8u is currently frozen pending release of 8u242. I prepared and successfully tested the backport and posted an RFR today asking to push to the jdk8u-dev tree. So, it ought to be available in u252 released in early April.

@gsmet
Copy link
Member Author

gsmet commented Jan 6, 2020

@thomaswue so to keep you in the loop, most issues are fixed except:

Thanks.

@gsmet gsmet added the triage/out-of-date This issue/PR is no longer valid or relevant label Apr 7, 2020
@gsmet gsmet closed this as completed Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/epic Large issue with links to sub-issues triage/out-of-date This issue/PR is no longer valid or relevant
Projects
None yet
Development

No branches or pull requests

5 participants