Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarkus OIDC and HTTPS improvements #7543

Closed
sberyozkin opened this issue Mar 3, 2020 · 3 comments
Closed

Quarkus OIDC and HTTPS improvements #7543

sberyozkin opened this issue Mar 3, 2020 · 3 comments
Labels
area/oidc kind/enhancement New feature or request
Milestone

Comments

@sberyozkin
Copy link
Member

sberyozkin commented Mar 3, 2020

Description
We've agreed with Pedro that it is worth investing more time into testing and documenting that the code grants/introspection requests can go via HTTPS, and also possibly support a custom trust/key stores for the 2-way TLS. This follows a user query how to get Keycloak CA verified.

CC @pedroigor

@sberyozkin sberyozkin added kind/enhancement New feature or request area/oidc labels Mar 3, 2020
@sberyozkin
Copy link
Member Author

We have also discussed the security of the various client authentication methods with @emmanuelbernard at the forum. The proposal is to warn the users that a client secret may be leaked if auth-server-url is insecure HTTP one and either client_secret_basic or client_secret_post is used.

CC @pedroigor

The only possible side-effect is if OIDC is collocated somewhere in the same protected zone when HTTP is enough ?

@sberyozkin
Copy link
Member Author

Or we can go even further and introduce the auto method selection, example, if it is HTTP and OIDC supports client_server_basic, client_server_post and client_server_jwt then we auto select client_server_jwt but I suspect that may have some unexpected side-effects, so we probably should keep to _basic as a default and then let users to choose based on their requirements

@sberyozkin
Copy link
Member Author

I'm going to close this one because we have a test confirming the HTTPS connection works now, we can reopen more specific TLS related issues going forward

@sberyozkin sberyozkin added this to the 1.4.0 milestone Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/oidc kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant