Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should be ManagedExecutor in the Reactive Messaging Doc #8371

Closed
murphye opened this issue Apr 2, 2020 · 7 comments · Fixed by #19424
Closed

Should be ManagedExecutor in the Reactive Messaging Doc #8371

murphye opened this issue Apr 2, 2020 · 7 comments · Fixed by #19424
Assignees
Labels
area/documentation area/housekeeping Issue type for generalized tasks not related to bugs or enhancements
Milestone

Comments

@murphye
Copy link

murphye commented Apr 2, 2020

There is an error on the doc here:
https://quarkus.io/guides/reactive-messaging#implementing-fire-and-forget-interactions

Not correct:
@Inject Executor executor;

Correct:
@Inject ManagedExecutor executor;

@murphye murphye added the area/housekeeping Issue type for generalized tasks not related to bugs or enhancements label Apr 2, 2020
@murphye
Copy link
Author

murphye commented Apr 3, 2020

Opening issue for website.

@murphye murphye closed this as completed Apr 3, 2020
@gsmet gsmet reopened this Apr 7, 2020
@gsmet
Copy link
Member

gsmet commented Apr 7, 2020

Reopening as the doc are maintained here.

@cescoffier @FroMage could you check and fix if needed?

@FroMage
Copy link
Member

FroMage commented Apr 8, 2020

Mmm, I wonder if it's required. ManagedExecutor is an Executor, so it would work unless there are other Executor beans, and I'm not sure there are in Quarkus. I'd have to actually try this code out to know.

@FroMage
Copy link
Member

FroMage commented Apr 8, 2020

@cescoffier I assume you did try that example code?

@gsmet
Copy link
Member

gsmet commented Apr 8, 2020

Well, if it doesn't hurt, I would be in favor of using ManagedExecutor.

Having some other Executor bean could be quite frequent.

@gsmet gsmet self-assigned this May 7, 2020
@loicmathieu
Copy link
Contributor

If it's still needed, I can take care of this one.

@cescoffier
Copy link
Member

I just opened a PR.

@quarkus-bot quarkus-bot bot added this to the 2.2 - main milestone Aug 17, 2021
@gsmet gsmet modified the milestones: 2.2 - main, 2.1.3.Final Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation area/housekeeping Issue type for generalized tasks not related to bugs or enhancements
Projects
None yet
5 participants