Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for persistence.xml for Hibernate Reactive #9859

Closed
Sanne opened this issue Jun 8, 2020 · 3 comments · Fixed by #9872
Closed

Remove support for persistence.xml for Hibernate Reactive #9859

Sanne opened this issue Jun 8, 2020 · 3 comments · Fixed by #9872
Assignees
@aguibert
Labels
area/hibernate-orm Hibernate ORM area/hibernate-reactive area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/persistence
Milestone
1.6.0.CR1

Comments

@Sanne
Copy link
Member

Sanne commented Jun 8, 2020

Description
Currently the Hibernate Reactive extension is able to use a persistence.xml as a configuration file; this capability was inherited from the Hibernate ORM extension but we shouldn't allow it.

We should remove this soon, as it's easier to remove such things before it's included in a release.
@Sanne Sanne added area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/hibernate-reactive labels Jun 8, 2020
@Sanne Sanne mentioned this issue Jun 8, 2020
Merged
@quarkusbot
Copy link

/cc @gsmet @Sanne

@aguibert
Copy link
Member

aguibert commented Jun 8, 2020

I plan to work on this one

@aguibert aguibert self-assigned this Jun 8, 2020
@Sanne
Copy link
Member Author

Sanne commented Jun 8, 2020

great, thanks @aguibert .

@Sanne Sanne mentioned this issue Jun 8, 2020
Merged
@aguibert aguibert mentioned this issue Jun 8, 2020
Merged
@Sanne Sanne added this to the 1.6.0 - master milestone Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aguibert aguibert

Labels
area/hibernate-orm Hibernate ORM area/hibernate-reactive area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/persistence
Projects
None yet
Milestone
1.6.0.CR1
Development

Successfully merging a pull request may close this issue.

Block usage of persistence.xml for Hibernate Reactive aguibert/quarkus
3 participants
@Sanne @aguibert @quarkusbot