Replaces Travis with GitHub Actions #791
Conversation
|
🎊 PR Preview 220a33e has been successfully built and deployed to https://quarkusio-quarkusio-github-io-preview-pr-791.surge.sh 🕐 Build time: 0.013s
🤖 By surge-preview |
gastaldi
force-pushed
the
gh_action
branch
4 times, most recently
from
f2d6073
to
20c6ba0
Compare
| @@ -0,0 +1,26 @@ | |||
| name: Build and deploy to GitHub Pages | |||
There was a problem hiding this comment.
as long as we can't guarantee there are a action resources free should we not just use gtihub actions for PR and still keep travis.yml for master/develop builds ?
There was a problem hiding this comment.
IMHO I don't think it's worth the trouble of having 2 CIs (and consequently 2 build scripts) for a single task.
It's highly likely that the time that Travis takes to build the master branch (due to the resource limits imposed) would take longer than the time it takes the GH Action to execute (even in high load scenarios).
So I'm -1 on that.
There was a problem hiding this comment.
Considering the issue we have with Travis, I think it's worth a try.
But we might have to revert this if it ends up being impractical.
There was a problem hiding this comment.
In the worst case scenario you can always run the build locally 😉
There was a problem hiding this comment.
I added instructions on how to deploy to GitHub pages locally if you ever need to
gastaldi
force-pushed
the
gh_action
branch
4 times, most recently
from
cf7e206
to
c1a4cdc
Compare
This removes the Travis descriptor and builds using GitHub actions and builds daily Add instructions on how to deploy to Github pages locally
|
OK, let's try this and see how it goes! Thanks! |
This removes the Travis descriptor and builds using GitHub actions and builds daily