Attempt to reduce the number of style recalc #942
Conversation
|
We could also try to skip this part completely: https://github.com/quarkusio/quarkusio.github.io/blob/develop/_guides/javascript/config.js#L257-L260 |
|
♻️ PR Preview a1fc09b has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
Actually, I believe we need to work on the shadow table for this to work. Lemme give it a try. But damn I had garbage collected the memory of this :( |
|
I've done this with a shadow DOM, at the cost of some false positives, but the time required for setting it up is now down to 250ms on my machine. We should have done this long ago, but initially there was no need since we had much fewer entries. The problem is that our script doesn't get called until quite a long time, because something is taking forever and delays the page load. I'm not sure what, though. |
|
Note that this actually needs fixing in the quarkus repo, not just here. |
|
+1 I've tried the the preview page and it seems to load faster... |
|
@FroMage I can merge it for sure. I'll let you fix it in the Quarkus repo as you said it was needed? |
well, yeah, that's the source, when you make a release, no? |
|
Yes if this file is coming from the main repo, it needs an update before the next release (probably next Wednesday). |
Same changes as for quarkusio/quarkusio.github.io#942: use shadow DOM while building the page to make it load faster
|
Done: quarkusio/quarkus#16436 |
Same changes as for quarkusio/quarkusio.github.io#942: use shadow DOM while building the page to make it load faster (cherry picked from commit 83917ba)
This could help a little. Unfortunately, I can't test the whole site locally (no functional ruby env here).