Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search bug when the search index contains HTML code for a redirect (HTML book) #4404

Closed
4 tasks done
maelle opened this issue Feb 17, 2023 · 0 comments
Closed
4 tasks done
Assignees
Labels
bug Something isn't working
Milestone

Comments

@maelle
Copy link
Contributor

maelle commented Feb 17, 2023

Bug description

@jonthegeek noticed that when searching for "ht" in https://devdevguide.netlify.app/ he was redirected to a non-existing page immediately.

I was able to reproduce the bug with a minimal example https://github.com/maelle/search-bug

In https://github.com/maelle/search-bug/blob/main/summary.qmd I added the necessary Markdown including html code for a redirect (which is something we need to explain to readers of the original book). That code is present in the search index. If you search for "ht" in https://maelle.github.io/search-bug/ you'll get redirected to https://docs.ropensci.org/%3Cpkgname%3E/

I'm guessing it has something to do with the code not being escaped somehow? Yes, that's a very vague guess. 😅 And a potentially very niche problem.

RStudio 2022.12.0+353 "Elsbeth Geranium" Release (7d165dcfc1b6d300eb247738db2c7076234f6ef0, 2022-12-03) for Ubuntu Bionic Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) rstudio/2022.12.0+353 Chrome/102.0.5005.167 Electron/19.1.3 Safari/537.36 Ubuntu

Checklist

  • Please include a minimal, fully reproducible example in a single .qmd file? Please provide the whole file rather than the snippet you believe is causing the issue.
  • Please format your issue so it is easier for us to read the bug report.
  • Please document the RStudio IDE version you're running (if applicable), by providing the value displayed in the "About RStudio" main menu dialog?
  • Please document the operating system you're running. If on Linux, please provide the specific distribution.
@maelle maelle added the bug Something isn't working label Feb 17, 2023
@maelle maelle changed the title Search bug when the search index contains HTML code for a redirect Search bug when the search index contains HTML code for a redirect (HTML book) Feb 17, 2023
@dragonstyle dragonstyle self-assigned this Feb 20, 2023
@dragonstyle dragonstyle added this to the v1.3 milestone Feb 20, 2023
maelle added a commit to ropensci/dev_guide that referenced this issue Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants