Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo actions (edit, source, issue) don't obey link-external-newwindow: true #5964

Closed
declann opened this issue Jun 18, 2023 · 1 comment
Closed
Assignees
Labels
bug Something isn't working triaged-to Issues that were not self-assigned, signals that an issue was assigned to someone.
Milestone

Comments

@declann
Copy link

declann commented Jun 18, 2023

Bug description

Hi,

I really like the repo actions!

I have a draft website here where I use them:

https://models-on-a-plane.pages.dev/

In the footer there is a link to calculang on GitHub, which opens in a new window, due to link-external-newwindow: true.

The Edit this page, View Source and Report an issue links alongside them ("Repo actions links") don't follow the same behaviour.

Steps to reproduce

https://gitlab.com/declann/models-on-a-plane

_quarto.yml has:

  repo-url: https://gitlab.com/declann/models-on-a-plane
  issue-url: https://gitlab.com/declann/models-on-a-plane/-/issues
  repo-actions:
    - edit
    - source
    - issue

and also link-external-newwindow: true

Expected behavior

Repo actions links should obey link-external-newwindow i.e. open in a new window whenever set to true

Actual behavior

Repo actions links take the user away from website

Your environment

No response

Quarto check output

[✓] Checking versions of quarto binary dependencies...
      Pandoc version 3.1.2: OK
      Dart Sass version 1.55.0: OK
      Deno version 1.33.2: OK
[✓] Checking versions of quarto dependencies......OK
[✓] Checking Quarto installation......OK
      Version: 1.4.151
      Path: /opt/quarto/bin
@declann declann added the bug Something isn't working label Jun 18, 2023
@mcanouil mcanouil added the triaged-to Issues that were not self-assigned, signals that an issue was assigned to someone. label Jun 18, 2023
@dragonstyle dragonstyle added this to the v1.4 milestone Jul 7, 2023
@dragonstyle
Copy link
Collaborator

Note that we elected not to support link-external-newwindow (as we intentionally don't decorate or have internal links gain this behavior). Instead, use repo-link-target and/or repo-link-rel to set corresponding attributes of repo links.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triaged-to Issues that were not self-assigned, signals that an issue was assigned to someone.
Projects
None yet
Development

No branches or pull requests

3 participants