Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quarto preview displays listing page instead of edited page when hot reloading #6026

Closed
mfisher87 opened this issue Jun 25, 2023 · 6 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@mfisher87
Copy link

Bug description

Repro repo: https://github.com/mfisher87/sscce-quarto-preview-hot-reload-listing

Either use this repo to test, or find details below.

When editing a page that is part of listing, quarto preview will hot reload.

In Quarto 1.3.361 and prior, the edited page was correctly displayed after the hot reload.

In Quarto 1.3.427, the listing page is displayed instead.

Steps to reproduce

  • quarto create-project --type website
  • mkdir listing
  • Create listing/index.md with barebones listing front-matter.
  • Edit _quarto.yml to add a link to listing/index.md.
  • Create listing/foo.md with barebones content.

Try the following steps with different versions of Quarto

  • quarto preview
  • Edit listing/foo.md, and write.
  • The browser will refresh automatically. Is the test post displayed, or is the listing
    page displayed?
    • In Quarto 1.3.427, the latter is the case, which is unintuitive to me. In
      previous versions, the former is the case. I expect the page I edited to be
      displayed!

Expected behavior

When editing a page, triggering a hot reload by quarto preview, I expect to see the page I edited.

Actual behavior

If the edited page is part of a listing, the listing index is displayed instead of the edited page in Quarto 1.3.427.

Your environment

Ubuntu 22
Quarto 1.3.427

Quarto check output

$ quarto check

[✓] Checking versions of quarto binary dependencies...
      Pandoc version 3.1.1: OK
      Dart Sass version 1.58.3: OK
[✓] Checking versions of quarto dependencies......OK
[✓] Checking Quarto installation......OK
      Version: 1.3.427
      Path: /home/robatt/.local/share/miniconda3/envs/itsarobin-homepage/bin

[✓] Checking basic markdown render....OK

[✓] Checking Python 3 installation....OK
      Version: 3.11.4 (Conda)
      Path: /home/robatt/.local/share/miniconda3/envs/itsarobin-homepage/bin/python
      Jupyter: 5.3.1
      Kernels: python3

(-) Checking Jupyter engine render....0.00s - Debugger warning: It seems that frozen modules are being used, which may
0.00s - make the debugger miss breakpoints. Please pass -Xfrozen_modules=off
0.00s - to python to disable frozen modules.
0.00s - Note: Debugging will proceed. Set PYDEVD_DISABLE_FILE_VALIDATION=1 to disable this validation.
0.00s - Debugger warning: It seems that frozen modules are being used, which may
0.00s - make the debugger miss breakpoints. Please pass -Xfrozen_modules=off
0.00s - to python to disable frozen modules.
0.00s - Note: Debugging will proceed. Set PYDEVD_DISABLE_FILE_VALIDATION=1 to disable this validation.
[✓] Checking Jupyter engine render....OK

[✓] Checking R installation...........(None)

      Unable to locate an installed version of R.
      Install R from https://cloud.r-project.org/
@mfisher87 mfisher87 added the bug Something isn't working label Jun 25, 2023
@dragonstyle dragonstyle self-assigned this Jun 26, 2023
@dragonstyle dragonstyle added this to the v1.4 milestone Jun 26, 2023
@dragonstyle
Copy link
Collaborator

Potentially introduced here:
2f9f231

@dragonstyle
Copy link
Collaborator

I've made the fix to the 1.4 (main) branch and will back port to 1.3 branch for our next patch release, which is likely a couple weeks away. Thx for reporting this was an unexpected side effect and a great thing to fix.

@mfisher87
Copy link
Author

Wonderful, thanks ❤️

If you drop me a ping/mention when the 1.3 backport is available, I'll get it released to conda-forge ASAP :)

dragonstyle added a commit that referenced this issue Jul 6, 2023
mfisher87 added a commit to mfisher87/quarto-feedstock that referenced this issue Jul 24, 2023
I'm backporting the TinyTex installation fix because v1.3.433 suffers
from:

quarto-dev/quarto-cli#6026
@mfisher87
Copy link
Author

Hey @dragonstyle is a backport release still planned? Thanks :)

@dragonstyle
Copy link
Collaborator

Apologies for the delay! Yes it should be coming this afternoon (within the next couple of hours). I'll update here when it is completed.

@mfisher87
Copy link
Author

Apologies for the delay!

No sweat, I understand you're busy! Thanks very much, Charles :) I've got it on my list later tonight to open a PR on the conda-forge feedstock.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants