Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: output-location values not displayed as code #6259

Closed
wants to merge 2 commits into from

Conversation

mcanouil
Copy link
Collaborator

@mcanouil mcanouil commented Jul 17, 2023

This PR fixes an inconsistency of the possible values for output-location where column was surrounded with single quote.

image

@mcanouil mcanouil changed the title fix: output-column values not displayed as code fix: output-location values not displayed as code Jul 17, 2023
@mcanouil mcanouil requested a review from cwickham July 17, 2023 20:11
@mcanouil mcanouil added the documentation Doc improvements & quarto-web label Jul 17, 2023
@mcanouil mcanouil requested a review from cderv July 17, 2023 22:01
Copy link
Collaborator

@cderv cderv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@mcanouil
Copy link
Collaborator Author

I updated this PR to revert quarto build-js to avoid current and future conflicts, thus the command will be required on merge.

@cderv
Copy link
Collaborator

cderv commented Sep 25, 2023

@mcanouil sorry I missed this in August. This should be already fixed: 13f89b1

- `column`: In an adjacent column

- `column`: In an adjacent column

🤔

And also it seems website needs a correct rebuild. I'll fix this.

Not sure why the PR changes is not showing that.

@cderv
Copy link
Collaborator

cderv commented Sep 25, 2023

And also it seems website needs a correct rebuild. I'll fix this.

This is because files on quarto-web are not updated from the ones in CLI. 🤔
https://github.com/search?q=repo%3Aquarto-dev%2Fquarto-web+%22In+an+adjacent+column%22+path%3A%2F%5Edocs%5C%2Freference%5C%2Fcells%5C%2F%2F&type=code

@dragonstyle can you remind us how references are update on quarto-web ? This will be done when we prepare 1.4 release right ?

It was done all in one go for 1.3 last time: quarto-dev/quarto-web@5f513d0

So @mcanouil I think we are good, and this could be closed.

@mcanouil
Copy link
Collaborator Author

I'll let you close this if this was corrected since I made the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Doc improvements & quarto-web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants