Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

links not clickable in margin column sidebar #8311

Closed
KaiWaldrant opened this issue Jan 17, 2024 · 1 comment · Fixed by #8313
Closed

links not clickable in margin column sidebar #8311

KaiWaldrant opened this issue Jan 17, 2024 · 1 comment · Fixed by #8313
Assignees
Labels
bug Something isn't working html Issues with HTML and related web technology (html/css/scss)
Milestone

Comments

@KaiWaldrant
Copy link

Bug description

When adding a margin column sidebar while adding the setting page-layout: full the content is not clickable like e.g. links added. This has also been tested with latest pre-release.

Steps to reproduce

with the code below it is not possible to click the links in the margin sidebar. when removing the page-layout: full setting everything works again.

---
title: "quarto margin sidebar links nor working"
format: html
page-layout: full
title-block-banner: true
toc: false
---


::: {.column-margin}

### Info

ID: `bd_rhapsody`  
Namespace: `ingestion`

### Links
[Source](https://github.com/openpipelines-bio/openpipeline/blob/0.12.1/./workflows/ingestion/bd_rhapsody){.btn-action .btn-sm .btn-info .btn role="button"}

:::

Testing if the url in the margin sidebar are working.
increaasing the size of the body
increaasing the size of the body

increaasing the size of the body
increaasing the size of the body

increaasing the size of the body

increaasing the size of the body

increaasing the size of the body

increaasing the size of the body

increaasing the size of the body
increaasing the size of the body
increaasing the size of the body
increaasing the size of the body
increaasing the size of the body

increaasing the size of the body

increaasing the size of the body

increaasing the size of the body

Expected behavior

The content should be clickable like e.g. links in the margin.

Actual behavior

The links are not clickable

Your environment

Fedora 37

Quarto check output

[✓] Checking versions of quarto binary dependencies...
      Pandoc version 3.1.1: OK
      Dart Sass version 1.55.0: OK
[✓] Checking versions of quarto dependencies......OK
[✓] Checking Quarto installation......OK
      Version: 1.3.450
      Path: /home/kai/opt/quarto-1.3.450/bin

[✓] Checking basic markdown render....OK

[✓] Checking Python 3 installation....OK
      Version: 3.10.9 (Conda)
      Path: /home/kai/anaconda3/bin/python
      Jupyter: 5.2.0
      Kernels: python3

[✓] Checking Jupyter engine render....OK

[✓] Checking R installation...........OK
      Version: 4.2.3
      Path: /usr/lib64/R
      LibPaths:
        - /home/kai/R/x86_64-redhat-linux-gnu-library/4.2
        - /usr/lib64/R/library
        - /usr/share/R/library
      knitr: 1.43
      rmarkdown: 2.23

[✓] Checking Knitr engine render......OK
Quarto 1.4.543
[✓] Checking versions of quarto binary dependencies...
      Pandoc version 3.1.11: OK
      Dart Sass version 1.69.5: OK
      Deno version 1.37.2: OK
[✓] Checking versions of quarto dependencies......OK
[✓] Checking Quarto installation......OK
      Version: 1.4.543
      Path: /home/kai/opt/quarto-1.4.543/bin

[✓] Checking tools....................OK
      TinyTeX: (not installed)
      Chromium: (not installed)

[✓] Checking LaTeX....................OK
      Using: Installation From Path
      Path: /usr/bin
      Version: 2021

[✓] Checking basic markdown render....OK

[✓] Checking Python 3 installation....OK
      Version: 3.10.9 (Conda)
      Path: /home/kai/anaconda3/bin/python
      Jupyter: 5.2.0
      Kernels: python3

[✓] Checking Jupyter engine render....OK

[✓] Checking R installation...........OK
      Version: 4.2.3
      Path: /usr/lib64/R
      LibPaths:
        - /home/kai/R/x86_64-redhat-linux-gnu-library/4.2
        - /usr/lib64/R/library
        - /usr/share/R/library
      knitr: 1.43
      rmarkdown: 2.23

[✓] Checking Knitr engine render......OK
@KaiWaldrant KaiWaldrant added the bug Something isn't working label Jan 17, 2024
@cderv
Copy link
Collaborator

cderv commented Jan 17, 2024

Thanks for the report

I believe this is a z-index issue as the margin side bar will be above the main content which was extended as full layout, but will be under

#quarto-content.page-columns {
#quarto-margin-sidebar,
#quarto-sidebar {
z-index: 1;
}
@include media-breakpoint-down(lg) {
#quarto-margin-sidebar.collapse,
#quarto-sidebar.collapse,
#quarto-margin-sidebar.collapsing,
#quarto-sidebar.collapsing {
z-index: $zindex-modal;
}
}
main.column-page,
main.column-page-right,
main.column-page-left {
z-index: 0;
}
}

This leads to the button and links not being seen as clickable when the mouse goes over as the margin div is on top.

@mcanouil mcanouil added triaged-to Issues that were not self-assigned, signals that an issue was assigned to someone. html Issues with HTML and related web technology (html/css/scss) labels Jan 17, 2024
dragonstyle added a commit that referenced this issue Jan 17, 2024
… z-order

Since the margin element has no children, we can safely push it to the bottom (and in fact, we need to in order to ensure that the links and other elements in the margin are clickable).

Fixes #8311
dragonstyle added a commit that referenced this issue Jan 17, 2024
… z-order

Since the margin element has no children, we can safely push it to the bottom (and in fact, we need to in order to ensure that the links and other elements in the margin are clickable).

Fixes #8311
@cderv cderv removed the triaged-to Issues that were not self-assigned, signals that an issue was assigned to someone. label Jan 17, 2024
@dragonstyle dragonstyle added this to the v1.5 milestone Jan 17, 2024
dragonstyle added a commit that referenced this issue Jan 24, 2024
Since the margin element has no children, we can safely push it to the bottom (and in fact, we need to in order to ensure that the links and other elements in the margin are clickable).

Fixes #8311
dragonstyle added a commit that referenced this issue Jan 24, 2024
Since the margin element has no children, we can safely push it to the bottom (and in fact, we need to in order to ensure that the links and other elements in the margin are clickable).

Fixes #8311
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working html Issues with HTML and related web technology (html/css/scss)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants