Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docusaurus] Table having many columns output from knitr with df-print: kable seems broken (Quarto 1.4) #8332

Open
eitsupi opened this issue Jan 18, 2024 · 12 comments
Assignees
Labels
bug Something isn't working docusaurus pandoc upstream Bug is in upstream library
Milestone

Comments

@eitsupi
Copy link
Contributor

eitsupi commented Jan 18, 2024

Bug description

Sorry for rewriting it so many times, I haven't been able to understand the exact conditions for this bug, but it looks like at least it happens in the Docusaurus format and not in knitr::knit or rmarkdown::render.

Steps to reproduce

---
title: foo
format:
    docusaurus-md:
        df-print: kable
---

```{r}
1:100 |>
  as.character() |>
  t() |>
  as.data.frame()
```

Expected behavior

---
title: foo
format:
  docusaurus-md:
    df-print: kable
---

``` r
1:100 |>
  as.character() |>
  t() |>
  as.data.frame()
```

| V1  | V2  | V3  | V4  | V5  | V6  | V7  | V8  | V9  | V10 | V11 | V12 | V13 | V14 | V15 | V16 | V17 | V18 | V19 | V20 | V21 | V22 | V23 | V24 | V25 | V26 | V27 | V28 | V29 | V30 | V31 | V32 | V33 | V34 | V35 | V36 | V37 | V38 | V39 | V40 | V41 | V42 | V43 | V44 | V45 | V46 | V47 | V48 | V49 | V50 | V51 | V52 | V53 | V54 | V55 | V56 | V57 | V58 | V59 | V60 | V61 | V62 | V63 | V64 | V65 | V66 | V67 | V68 | V69 | V70 | V71 | V72 | V73 | V74 | V75 | V76 | V77 | V78 | V79 | V80 | V81 | V82 | V83 | V84 | V85 | V86 | V87 | V88 | V89 | V90 | V91 | V92 | V93 | V94 | V95 | V96 | V97 | V98 | V99 | V100 |
|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|:-----|
| 1   | 2   | 3   | 4   | 5   | 6   | 7   | 8   | 9   | 10  | 11  | 12  | 13  | 14  | 15  | 16  | 17  | 18  | 19  | 20  | 21  | 22  | 23  | 24  | 25  | 26  | 27  | 28  | 29  | 30  | 31  | 32  | 33  | 34  | 35  | 36  | 37  | 38  | 39  | 40  | 41  | 42  | 43  | 44  | 45  | 46  | 47  | 48  | 49  | 50  | 51  | 52  | 53  | 54  | 55  | 56  | 57  | 58  | 59  | 60  | 61  | 62  | 63  | 64  | 65  | 66  | 67  | 68  | 69  | 70  | 71  | 72  | 73  | 74  | 75  | 76  | 77  | 78  | 79  | 80  | 81  | 82  | 83  | 84  | 85  | 86  | 87  | 88  | 89  | 90  | 91  | 92  | 93  | 94  | 95  | 96  | 97  | 98  | 99  | 100  |

Generated by Quarto 1.4.432

Actual behavior

---
title: foo
format:
  docusaurus-md:
    df-print: kable
---





```r
1:100 |>
  as.character() |>
  t() |>
  as.data.frame()
```

| V1  | V2  | V3  | V4  | V5  | V6  | V7  | V8  | V9  | V10 | V11 | V12 | V13 | V14 | V15 | V16 | V17 | V18 | V19 | V20 | V21 | V22 | V23 | V24 | V25 | V26 | V27 | V28 | V29 | V30 | V31 | V32 | V33 | V34 | V35 | V36 | V37 | V38 | V39 | V40 | V41 | V42 | V43 | V44 | V45 | V46 | V47 | V48 | V49 | V50 | V51 | V52 | V53 | V54 | V55 | V56 | V57 | V58 | V59 | V60 | V61 | V62 | V63 | V64 | V65 | V66 | V67 | V68 | V69 | V70 | V71 | V72 | V73 | V74 | V75 | V76 | V77 | V78 | V79 | V80 | V81 | V82 | V83 | V84 | V85 | V86 | V87 | V88 | V89 | V90 | V91 | V92 | V93 | V94 | V95 | V96 | V97 | V98 | V99 | V100 |
|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|
| 1   | 2   | 3   | 4   | 5   | 6   | 7   | 8   | 9   | 10  | 11  | 12  | 13  | 14  | 15  | 16  | 17  | 18  | 19  | 20  | 21  | 22  | 23  | 24  | 25  | 26  | 27  | 28  | 29  | 30  | 31  | 32  | 33  | 34  | 35  | 36  | 37  | 38  | 39  | 40  | 41  | 42  | 43  | 44  | 45  | 46  | 47  | 48  | 49  | 50  | 51  | 52  | 53  | 54  | 55  | 56  | 57  | 58  | 59  | 60  | 61  | 62  | 63  | 64  | 65  | 66  | 67  | 68  | 69  | 70  | 71  | 72  | 73  | 74  | 75  | 76  | 77  | 78  | 79  | 80  | 81  | 82  | 83  | 84  | 85  | 86  | 87  | 88  | 89  | 90  | 91  | 92  | 93  | 94  | 95  | 96  | 97  | 98  | 99  | 100  |

Your environment

  • Ubuntu 22.04

Quarto check output

$ quarto check   
Quarto 1.4.545
[✓] Checking versions of quarto binary dependencies...
      Pandoc version 3.1.11: OK
      Dart Sass version 1.69.5: OK
      Deno version 1.37.2: OK
[✓] Checking versions of quarto dependencies......OK
[✓] Checking Quarto installation......OK
      Version: 1.4.545
      Path: /opt/quarto/bin

[✓] Checking tools....................OK
      TinyTeX: (not installed)
      Chromium: (not installed)

[✓] Checking LaTeX....................OK
      Tex:  (not detected)

[✓] Checking basic markdown render....OK

[✓] Checking Python 3 installation....OK
      Version: 3.10.12
      Path: /usr/local/python/current/bin/python3
      Jupyter: 5.7.1
      Kernels: python3

[✓] Checking Jupyter engine render....OK

[✓] Checking R installation...........OK
      Version: 4.3.2
      Path: /usr/local/lib/R
      LibPaths:
        - /workspaces/querying-with-prql/renv/library/R-4.3/x86_64-pc-linux-gnu
        - /usr/local/lib/R/library
      knitr: 1.45
      rmarkdown: 2.25

[✓] Checking Knitr engine render......OK
@eitsupi eitsupi added the bug Something isn't working label Jan 18, 2024
@eitsupi eitsupi changed the title [Docusaurus] Table output from knitr seems broken (Quarto 1.4) [Docusaurus] Table output from knitr with df-print: kable seems broken (Quarto 1.4) Jan 18, 2024
@eitsupi eitsupi changed the title [Docusaurus] Table output from knitr with df-print: kable seems broken (Quarto 1.4) [Docusaurus] Table having many columns output from knitr with df-print: kable seems broken (Quarto 1.4) Jan 18, 2024
@eitsupi eitsupi changed the title [Docusaurus] Table having many columns output from knitr with df-print: kable seems broken (Quarto 1.4) Table having many columns output from knitr with df-print: kable seems broken (Quarto 1.4) Jan 18, 2024
@eitsupi eitsupi changed the title Table having many columns output from knitr with df-print: kable seems broken (Quarto 1.4) [markdown] Table having many columns output from knitr with df-print: kable seems broken (Quarto 1.4) Jan 18, 2024
@eitsupi eitsupi changed the title [markdown] Table having many columns output from knitr with df-print: kable seems broken (Quarto 1.4) [Docusaurus] Table having many columns output from knitr with df-print: kable seems broken (Quarto 1.4) Jan 18, 2024
@cderv
Copy link
Collaborator

cderv commented Jan 18, 2024

What do you mean by broken exactly ? Does pipe table syntax matters in the docusaurus rendering ? Do you see some impact ?

They both have pipe table just formatted a bit differently comparing spaces in number of - but I believe the two syntax are equivalent for pipe_tables

In short: The change from before to after conversion is the result of converting to markdown_strict+pipe_tables with Pandoc.

More detailed about this conclusion below


The intermediate Markdown is like this

---
title: foo
format:
    docusaurus-md:
        df-print: kable
keep-md: true
---


::: {.cell}

```{.r .cell-code}
1:100 |>
  as.character() |>
  t() |>
  as.data.frame()
```

::: {.cell-output-display}
<div class="kable-table">

|V1 |V2 |V3 |V4 |V5 |V6 |V7 |V8 |V9 |V10 |V11 |V12 |V13 |V14 |V15 |V16 |V17 |V18 |V19 |V20 |V21 |V22 |V23 |V24 |V25 |V26 |V27 |V28 |V29 |V30 |V31 |V32 |V33 |V34 |V35 |V36 |V37 |V38 |V39 |V40 |V41 |V42 |V43 |V44 |V45 |V46 |V47 |V48 |V49 |V50 |V51 |V52 |V53 |V54 |V55 |V56 |V57 |V58 |V59 |V60 |V61 |V62 |V63 |V64 |V65 |V66 |V67 |V68 |V69 |V70 |V71 |V72 |V73 |V74 |V75 |V76 |V77 |V78 |V79 |V80 |V81 |V82 |V83 |V84 |V85 |V86 |V87 |V88 |V89 |V90 |V91 |V92 |V93 |V94 |V95 |V96 |V97 |V98 |V99 |V100 |
|:--|:--|:--|:--|:--|:--|:--|:--|:--|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:----|
|1  |2  |3  |4  |5  |6  |7  |8  |9  |10  |11  |12  |13  |14  |15  |16  |17  |18  |19  |20  |21  |22  |23  |24  |25  |26  |27  |28  |29  |30  |31  |32  |33  |34  |35  |36  |37  |38  |39  |40  |41  |42  |43  |44  |45  |46  |47  |48  |49  |50  |51  |52  |53  |54  |55  |56  |57  |58  |59  |60  |61  |62  |63  |64  |65  |66  |67  |68  |69  |70  |71  |72  |73  |74  |75  |76  |77  |78  |79  |80  |81  |82  |83  |84  |85  |86  |87  |88  |89  |90  |91  |92  |93  |94  |95  |96  |97  |98  |99  |100  |

</div>
:::
:::

So knitr::kable() is outputting a pipe table - it seems just that from a certain number of column, the - are removed in the conversion. This is not linked to knitr. Try directly the markdown table

---
title: foo
format: docusaurus-md
keep-md: true
---


|V1 |V2 |V3 |V4 |V5 |V6 |V7 |V8 |V9 |V10 |
|:--|:--|:--|:--|:--|:--|:--|:--|:--|:---|
|1  |2  |3  |4  |5  |6  |7  |8  |9  |10  |

The mdx output table will be slightly different

---
title: foo
format: docusaurus-md
keep-md: true
---




| V1  | V2  | V3  | V4  | V5  | V6  | V7  | V8  | V9  | V10 |
|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|
| 1   | 2   | 3   | 4   | 5   | 6   | 7   | 8   | 9   | 10  |

And this is the result of Pandoc conversion. For docusaurus, as it is not a support Pandoc format, we write to markdown_strict adding some extension, one of them being +pipe_tables

And the result is the same with Pandoc directly

> quarto pandoc -t markdown_strict+pipe_tables

|V1 |V2 |V3 |V4 |V5 |V6 |V7 |V8 |V9 |V10 |
|:--|:--|:--|:--|:--|:--|:--|:--|:--|:---|
|1  |2  |3  |4  |5  |6  |7  |8  |9  |10  |

| V1  | V2  | V3  | V4  | V5  | V6  | V7  | V8  | V9  | V10 |
|:----|:----|:----|:----|:----|:----|:----|:----|:----|:----|
| 1   | 2   | 3   | 4   | 5   | 6   | 7   | 8   | 9   | 10  |
And same with the very long table produced by kable
> quarto pandoc -t markdown_strict+pipe_tables
|V1 |V2 |V3 |V4 |V5 |V6 |V7 |V8 |V9 |V10 |V11 |V12 |V13 |V14 |V15 |V16 |V17 |V18 |V19 |V20 |V21 |V22 |V23 |V24 |V25 |V26 |V27 |V28 |V29 |V30 |V31 |V32 |V33 |V34 |V35 |V36 |V37 |V38 |V39 |V40 |V41 |V42 |V43 |V44 |V45 |V46 |V47 |V48 |V49 |V50 |V51 |V52 |V53 |V54 |V55 |V56 |V57 |V58 |V59 |V60 |V61 |V62 |V63 |V64 |V65 |V66 |V67 |V68 |V69 |V70 |V71 |V72 |V73 |V74 |V75 |V76 |V77 |V78 |V79 |V80 |V81 |V82 |V83 |V84 |V85 |V86 |V87 |V88 |V89 |V90 |V91 |V92 |V93 |V94 |V95 |V96 |V97 |V98 |V99 |V100 |
|:--|:--|:--|:--|:--|:--|:--|:--|:--|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:----|
|1  |2  |3  |4  |5  |6  |7  |8  |9  |10  |11  |12  |13  |14  |15  |16  |17  |18  |19  |20  |21  |22  |23  |24  |25  |26  |27  |28  |29  |30  |31  |32  |33  |34  |35  |36  |37  |38  |39  |40  |41  |42  |43  |44  |45  |46  |47  |48  |49  |50  |51  |52  |53  |54  |55  |56  |57  |58  |59  |60  |61  |62  |63  |64  |65  |66  |67  |68  |69  |70  |71  |72  |73  |74  |75  |76  |77  |78  |79  |80  |81  |82  |83  |84  |85  |86  |87  |88  |89  |90  |91  |92  |93  |94  |95  |96  |97  |98  |99  |100  |

| V1  | V2  | V3  | V4  | V5  | V6  | V7  | V8  | V9  | V10 | V11 | V12 | V13 | V14 | V15 | V16 | V17 | V18 | V19 | V20 | V21 | V22 | V23 | V24 | V25 | V26 | V27 | V28 | V29 | V30 | V31 | V32 | V33 | V34 | V35 | V36 | V37 | V38 | V39 | V40 | V41 | V42 | V43 | V44 | V45 | V46 | V47 | V48 | V49 | V50 | V51 | V52 | V53 | V54 | V55 | V56 | V57 | V58 | V59 | V60 | V61 | V62 | V63 | V64 | V65 | V66 | V67 | V68 | V69 | V70 | V71 | V72 | V73 | V74 | V75 | V76 | V77 | V78 | V79 | V80 | V81 | V82 | V83 | V84 | V85 | V86 | V87 | V88 | V89 | V90 | V91 | V92 | V93 | V94 | V95 | V96 | V97 | V98 | V99 | V100 |
|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|
| 1   | 2   | 3   | 4   | 5   | 6   | 7   | 8   | 9   | 10  | 11  | 12  | 13  | 14  | 15  | 16  | 17  | 18  | 19  | 20  | 21  | 22  | 23  | 24  | 25  | 26  | 27  | 28  | 29  | 30  | 31  | 32  | 33  | 34  | 35  | 36  | 37  | 38  | 39  | 40  | 41  | 42  | 43  | 44  | 45  | 46  | 47  | 48  | 49  | 50  | 51  | 52  | 53  | 54  | 55  | 56  | 57  | 58  | 59  | 60  | 61  | 62  | 63  | 64  | 65  | 66  | 67  | 68  | 69  | 70  | 71  | 72  | 73  | 74  | 75  | 76  | 77  | 78  | 79  | 80  | 81  | 82  | 83  | 84  | 85  | 86  | 87  | 88  | 89  | 90  | 91  | 92  | 93  | 94  | 95  | 96  | 97  | 98  | 99  | 100  |

So this is pandoc behavior.

@eitsupi
Copy link
Contributor Author

eitsupi commented Jan 18, 2024

Thanks for your quick reply.
"Broken" means that Docusaurus doesn't recognize such a table as a table, so it's rendered as just a sentence.

|V1|V2|
|:-|:-|
|foo|bar|

|V1|V2|
|:|:|
|foo|bar|

will be rendered as:

image

@mcanouil
Copy link
Collaborator

mcanouil commented Jan 18, 2024

Why would the pipe table be transformed here in the first place?

This seems very wrong from Pandoc to remove all dash because what does |:| mean? Left aligned? Centered aligned? Right aligned? To me this is a bug that needs to be fixed by Pandoc.

@cderv
Copy link
Collaborator

cderv commented Jan 18, 2024

Yes agreed an issue could be opened on Pandoc side - I did not found the pipe table spec, but even with colon only, some online markdown table processor knows how to handle it.

FWIW the limit is with the example shared in OP is 72 columns

|V1 |V2 |V3 |V4 |V5 |V6 |V7 |V8 |V9 |V10 |V11 |V12 |V13 |V14 |V15 |V16 |V17 |V18 |V19 |V20 |V21 |V22 |V23 |V24 |V25 |V26 |V27 |V28 |V29 |V30 |V31 |V32 |V33 |V34 |V35 |V36 |V37 |V38 |V39 |V40 |V41 |V42 |V43 |V44 |V45 |V46 |V47 |V48 |V49 |V50 |V51 |V52 |V53 |V54 |V55 |V56 |V57 |V58 |V59 |V60 |V61 |V62 |V63 |V64 |V65 |V66 |V67 |V68 |V69 |V70 |V71 |V72 |
|:--|:--|:--|:--|:--|:--|:--|:--|:--|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|:---|
|1  |2  |3  |4  |5  |6  |7  |8  |9  |10  |11  |12  |13  |14  |15  |16  |17  |18  |19  |20  |21  |22  |23  |24  |25  |26  |27  |28  |29  |30  |31  |32  |33  |34  |35  |36  |37  |38  |39  |40  |41  |42  |43  |44  |45  |46  |47  |48  |49  |50  |51  |52  |53  |54  |55  |56  |57  |58  |59  |60  |61  |62  |63  |64  |65  |66  |67  |68  |69  |70  |71  |72  |
| V1  | V2  | V3  | V4  | V5  | V6  | V7  | V8  | V9  | V10 | V11 | V12 | V13 | V14 | V15 | V16 | V17 | V18 | V19 | V20 | V21 | V22 | V23 | V24 | V25 | V26 | V27 | V28 | V29 | V30 | V31 | V32 | V33 | V34 | V35 | V36 | V37 | V38 | V39 | V40 | V41 | V42 | V43 | V44 | V45 | V46 | V47 | V48 | V49 | V50 | V51 | V52 | V53 | V54 | V55 | V56 | V57 | V58 | V59 | V60 | V61 | V62 | V63 | V64 | V65 | V66 | V67 | V68 | V69 | V70 | V71 | V72 |
|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|:|
| 1   | 2   | 3   | 4   | 5   | 6   | 7   | 8   | 9   | 10  | 11  | 12  | 13  | 14  | 15  | 16  | 17  | 18  | 19  | 20  | 21  | 22  | 23  | 24  | 25  | 26  | 27  | 28  | 29  | 30  | 31  | 32  | 33  | 34  | 35  | 36  | 37  | 38  | 39  | 40  | 41  | 42  | 43  | 44  | 45  | 46  | 47  | 48  | 49  | 50  | 51  | 52  | 53  | 54  | 55  | 56  | 57  | 58  | 59  | 60  | 61  | 62  | 63  | 64  | 65  | 66  | 67  | 68  | 69  | 70  | 71  | 72  |

It will produce a table that even Pandoc won't process. If you put the first one in test.md then you get

pandoc -f markdown -t markdown_strict+pipe_tables test.md | pandoc -t native | head -10
[ LineBlock
    [ [ Str "V1"
      , Space
      , Str "|"
      , Space
      , Str "V2"
      , Space
      , Str "|"
      , Space
      , Str "V3"

So definitely a problem somewhere in the processing

@cderv
Copy link
Collaborator

cderv commented Jan 18, 2024

So it was indeed a bug in pandoc with how the number of - to use was calculated. It is fixed in dev pandoc, and so it will be available in Quarto when we include a new Pandoc version.

It seems a workaround is to set the --columns value (which default to 72 - hence why the issue happens at that number of column) to a greater value than the number of columns. So it could have impact on all your tables and other stuff.

Thanks again for the port. I'll mark this as future until we close when we update Pandoc.

Pandoc version that have the fix: next one > 3.1.11.1

@cderv cderv added this to the Future milestone Jan 18, 2024
@eitsupi
Copy link
Contributor Author

eitsupi commented Jan 19, 2024

It would be great to see the fix on the pandoc side. Thanks!

@eitsupi
Copy link
Contributor Author

eitsupi commented Jan 19, 2024

It seems a workaround is to set the --columns value (which default to 72 - hence why the issue happens at that number of column) to a greater value than the number of columns. So it could have impact on all your tables and other stuff.

I tried quarto render --columns=1000 in eitsupi/querying-with-prql@48fac25, but seems nothing happen.

Is there something wrong with the way I specify pandoc options?

@cderv
Copy link
Collaborator

cderv commented Jan 19, 2024

I suspect we are not passing the CLI flag that impacts the writer options to the custom docusaurus writers...
Let me check that.

@cderv
Copy link
Collaborator

cderv commented Jan 23, 2024

@eitsupi we merge the PR that has the scoped fix to support setting columns in YAML or through command line.

@eitsupi
Copy link
Contributor Author

eitsupi commented Jan 23, 2024

@eitsupi we merge the PR that has the scoped fix to support setting columns in YAML or through command line.

Confirmed, thanks!

@eitsupi
Copy link
Contributor Author

eitsupi commented Apr 13, 2024

Perhaps the Pandoc version has been updated so you can close this? (I would recommend adding a test to prevent regression)

@cderv cderv modified the milestones: Future, v1.5 Apr 13, 2024
@cderv cderv self-assigned this Apr 13, 2024
@cderv
Copy link
Collaborator

cderv commented Apr 13, 2024

Indeed thanks. I'll add a test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docusaurus pandoc upstream Bug is in upstream library
Projects
None yet
Development

No branches or pull requests

3 participants