pass writer options correctly for docusaurus-md #8365
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #8332 so that the workaround of setting
columns
works.See #8332 for details about the real issue that will be fixed in next Pandoc version
Problem was that setting
columns
is currently ignoredThis is because we use default PANDOC_WRITER_OPTIONS
quarto-cli/src/resources/extensions/quarto/docusaurus/docusaurus_citeproc.lua
Line 14 in 76d8d84
This PR pass writer options but for now only
columns
This is because passing all the
PANDOC_WRITER_OPTIONS
would have more impact that probably we don't want.Example setting
toc: true
has currently no effect. Passing the all options would then create markdown TOC in the output, which I believe is not supported by Docusaurus (and we don't do it in 1.3 either)So I would have expect this to be what to do (as I think the
Writer
worked like that) but it seems it is different@cscheid what is your take on this ? Do we need to check more writer options to determine which ones to let pass through ?
As we are so close to 1.4 release, I choose to keep this scoped to #8332
Other note: Setting
columns
in YAML does not work in 1.3 either. So this is a specific fix for #8332 workaround to work with docusaurus