Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --quiet support to quarto use template #8438

Closed
cderv opened this issue Jan 25, 2024 · 2 comments
Closed

Add --quiet support to quarto use template #8438

cderv opened this issue Jan 25, 2024 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@cderv
Copy link
Collaborator

cderv commented Jan 25, 2024

I noticed that quarto use binder has support for --quiet but not quarto use template

> quarto use template --help

  Usage:   quarto use template <target>
  Version: 99.9.9

  Description:

    Use a Quarto template for this directory or project.

  Options:

    -h, --help   - Show this help.
    --no-prompt  - Do not prompt to confirm actions

  Commands:

    help  [command]  - Show this help or the help of a sub-command.

  Examples:

    Use a template from Github: quarto use template <gh-org>/<gh-repo>

while

> quarto use binder --help

  Usage:   quarto use binder
  Version: 99.9.9

  Description:

    Configure the current project with Binder support.

  Options:

    -h, --help              - Show this help.
    --no-prompt             - Do not prompt to confirm actions
    --log         <file>    - Path to log file
    --log-level   <level>   - Log level (info, warning, error, critical)
    --log-format  <format>  - Log format (plain, json-stream)
    --quiet                 - Suppress console output.
    --profile               - Active project profile(s)

  Commands:

    help  [command]  - Show this help or the help of a sub-command.

  Examples:

    Configure project to use Binder: quarto use binder

This was noticed while trying to suppress output in quarto R package tests suite.

@cderv cderv added this to the v1.5 milestone Jan 25, 2024
@mcanouil mcanouil added the enhancement New feature or request label Jan 25, 2024
cderv added a commit to quarto-dev/quarto-r that referenced this issue Jan 25, 2024
@dragonstyle dragonstyle self-assigned this Jan 25, 2024
@dragonstyle dragonstyle added bug Something isn't working and removed enhancement New feature or request labels Jan 25, 2024
@dragonstyle
Copy link
Collaborator

This is an awesome catch - the log and quiet related options are actually global and aren't being properly forwarded to commands in sub commands (the first sub command gets those options, the rest do not). This likely affects some other commands that include sub commands!

@cderv
Copy link
Collaborator Author

cderv commented Jan 26, 2024

This is an awesome catch

Thanks ! This shows once again that we do find some interesting stuff when we play with our own product in other related project!

Thanks for the quick fix, I'll update the R package.

cderv added a commit to quarto-dev/quarto-r that referenced this issue Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants