Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightbox images descriptions don't work anymore with v1.4 #8607

Closed
ycrouin opened this issue Feb 5, 2024 · 1 comment 路 Fixed by #8611
Closed

Lightbox images descriptions don't work anymore with v1.4 #8607

ycrouin opened this issue Feb 5, 2024 · 1 comment 路 Fixed by #8611
Assignees
Labels
bug Something isn't working triaged-to Issues that were not self-assigned, signals that an issue was assigned to someone.
Milestone

Comments

@ycrouin
Copy link

ycrouin commented Feb 5, 2024

Bug description

Hi team 馃憢

With the lightbox extension, we used to be able to add descriptions to images. It doesn't seem to be supported with v1.4

Steps to reproduce

See example

Expected behavior

expected

Actual behavior

actual

Your environment

  • Quarto version: 1.4.549
  • OS: Ubuntu 20.04.6 LTS

Quarto check output

Quarto 1.4.549
[鉁揮 Checking versions of quarto binary dependencies...
      Pandoc version 3.1.11: OK
      Dart Sass version 1.69.5: OK
      Deno version 1.37.2: OK
[鉁揮 Checking versions of quarto dependencies......OK
[鉁揮 Checking Quarto installation......OK
      Version: 1.4.549
      Path: /opt/quarto/bin

[鉁揮 Checking tools....................OK
      Chromium: 869685
      TinyTeX: (not installed)

[鉁揮 Checking LaTeX....................OK
      Using: Installation From Path
      Path: /usr/bin
      Version: 2019

[鉁揮 Checking basic markdown render....OK

[鉁揮 Checking Python 3 installation....OK
      Version: 3.11.5 (Conda)
      Path: /home/ycrouin/miniconda3/bin/python
      Jupyter: 5.7.1
      Kernels: [omitted for brevity ...]

(|) Checking Jupyter engine render....Traceback (most recent call last):
  File "/opt/quarto/share/jupyter/jupyter.py", line 21, in <module>
    from notebook import notebook_execute, RestartKernel
  File "/opt/quarto/share/jupyter/notebook.py", line 14, in <module>
    from yaml import safe_load
ModuleNotFoundError: No module named 'yaml'
There is an unactivated Python environment in venv. Did you forget to activate it?

[鉁揮 Checking Jupyter engine render....OK
@ycrouin ycrouin added the bug Something isn't working label Feb 5, 2024
@cscheid cscheid added the triaged-to Issues that were not self-assigned, signals that an issue was assigned to someone. label Feb 5, 2024
@dragonstyle dragonstyle added this to the v1.5 milestone Feb 5, 2024
@dragonstyle
Copy link
Collaborator

This is correct (and accidental). We changed the way descriptions are read to better support descriptions that contain formatted. I'll fix- ty for catching this!

dragonstyle added a commit that referenced this issue Feb 5, 2024
Use the description attribute if it is present. Fixes #8607
dragonstyle added a commit that referenced this issue Feb 5, 2024
Use the description attribute if it is present. Fixes #8607
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triaged-to Issues that were not self-assigned, signals that an issue was assigned to someone.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants