Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layout-ncol issue with image layout and captions #8785

Closed
jgunstone opened this issue Feb 19, 2024 · 6 comments · Fixed by #8866
Closed

layout-ncol issue with image layout and captions #8785

jgunstone opened this issue Feb 19, 2024 · 6 comments · Fixed by #8866
Assignees
Labels
bug Something isn't working
Milestone

Comments

@jgunstone
Copy link

jgunstone commented Feb 19, 2024

Bug description

  • images aren't centred correctly above text
  • unwanted and unspecified (a), (b) ... etc. fig identifiers being added to images

Steps to reproduce

---
document_description: A description of the document that is important
footer-logo: logo.png
title-page: title-page.pdf
---

# Images

## A Red Circle

![Some red circle](./media/red-dot.png){width=30mm}

Above we can see an image of a red circle.

{{< pagebreak >}}

## Radiator Widths

::: {layout-ncol=3 layout-valign="bottom"}
![A logo](https://placehold.co/50x40.png){height=30mm}

![Another logo](https://placehold.co/50x40.png)

![Look at that, another logo!](https://placehold.co/50x40.png)
:::

Expected behavior

behaviour in v1.4.466
image

Actual behavior

behaviour in v1.4.550
image

with public images
image

Your environment

wsl, Ubuntu22.04, VS Code

Quarto check output

Quarto 1.4.550
[✓] Checking versions of quarto binary dependencies...
      Pandoc version 3.1.11: OK
      Dart Sass version 1.58.3: OK
      Deno version 1.37.2: OK
[✓] Checking versions of quarto dependencies......OK
[✓] Checking Quarto installation......OK
      Version: 1.4.550
      Path: /home/jovyan/miniforge3/envs/document-issue-dev/lib/python3.11/site-packages/quarto_cli/quarto-1.4.549/bin

[✓] Checking tools....................OK
      TinyTeX: v2024.02
      Chromium: (not installed)

[✓] Checking LaTeX....................OK
      Using: TinyTex
      Path: /home/jovyan/.TinyTeX/bin/x86_64-linux
      Version: 2023

[✓] Checking basic markdown render....OK

[✓] Checking Python 3 installation....OK
      Version: 3.10.13 (Conda)
      Path: /home/jovyan/miniforge3/bin/python
      Jupyter: (None)

      Jupyter is not available in this Python installation.
      Install with conda install jupyter

[✓] Checking R installation...........(None)

      Unable to locate an installed version of R.
      Install R from https://cloud.r-project.org/
@jgunstone jgunstone added the bug Something isn't working label Feb 19, 2024
@mcanouil mcanouil added crossref triaged-to Issues that were not self-assigned, signals that an issue was assigned to someone. labels Feb 19, 2024
@mcanouil
Copy link
Collaborator

@jgunstone thanks for the report, could you update your images to make your example reproducible?

![A placeholder image](https://placehold.co/50x40.png)

@mcanouil mcanouil added this to the v1.5 milestone Feb 19, 2024
@cscheid cscheid removed the crossref label Feb 19, 2024
@cscheid
Copy link
Collaborator

cscheid commented Feb 19, 2024

The presence of (a), (b), and (c) subfigure indicators is a difference between HTML and PDF behaviors, but I don't think it's a bug; we can't use LaTeX's mechanisms without creating them.

@jgunstone
Copy link
Author

@mcanouil - just updated with placeholder images...
@cscheid - is there a way to switch of the subfig indicators?

also the layout not being centred.... ?

@cscheid
Copy link
Collaborator

cscheid commented Feb 23, 2024

I've bisected the regression to 71de80c

@cscheid cscheid removed the triaged-to Issues that were not self-assigned, signals that an issue was assigned to someone. label Feb 23, 2024
@cscheid cscheid modified the milestones: v1.5, Hot-fix Feb 23, 2024
@cscheid cscheid closed this as completed Feb 23, 2024
@cscheid
Copy link
Collaborator

cscheid commented Feb 23, 2024

Fixed on main and backported to 1.4.

@jgunstone
Copy link
Author

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants