Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lua filter utils #1863

Merged
merged 2 commits into from Aug 15, 2022
Merged

Lua filter utils #1863

merged 2 commits into from Aug 15, 2022

Conversation

jmbuhr
Copy link
Contributor

@jmbuhr jmbuhr commented Aug 14, 2022

this PR exports quarto.base64 together with the already exported quarto.utils and quarto.json for use in lua filters. This is helpful for writing filters that can create self-contained htmls.

@jjallaire
Copy link
Collaborator

@cscheid I'm assuming that the addition to .gitignore is fine here?

@dragonstyle Are we okay with adding the quarto.base64 module or should we consider re-organizing to e.g. quarto.encoding.json, quarto.encoding.base64. I'm personally fine with quarto.base64 but just wanted to double-check with you.

@dragonstyle
Copy link
Collaborator

@dragonstyle Are we okay with adding the quarto.base64 module or should we consider re-organizing to e.g. quarto.encoding.json, quarto.encoding.base64. I'm personally fine with quarto.base64 but just wanted to double-check with you.

I think this makes sense at the root level too, vs trying to next everything in namespaces. I'm good with quarto.base64

@cscheid
Copy link
Collaborator

cscheid commented Aug 15, 2022

@jjallaire yeah, that looks safe. I was under the impression that we only keep those now when the vendoring process fails and we can't roll it back for whatever reason.

@jmbuhr Are you having issues with those files hanging onto your filesystem? Maybe we should open a separate gh issue to track.

@jmbuhr
Copy link
Contributor Author

jmbuhr commented Aug 15, 2022

@cscheid Yes. So I assume these where supposed to be deleted during the cleanup steps.
These are the files that stick around:

$ ls src/vendor-2022-08-15 
cdn.skypack.dev  deno.land  import_map.json

@cscheid
Copy link
Collaborator

cscheid commented Aug 15, 2022

@jmbuhr It seems that we're rolling back on failure but not throwing away the old version on success. Thanks for catching that! I'll fix right away.

@cscheid
Copy link
Collaborator

cscheid commented Aug 15, 2022

I just pushed a change to main that cleans those up. We can keep the .gitignore addition, but it should no longer be necessary.

@jjallaire jjallaire merged commit 2c90afd into quarto-dev:main Aug 15, 2022
@jmbuhr jmbuhr deleted the lua-filter-utils branch August 15, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants