Correctly detect a global sidebar and not a specific page sidebar #9741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
cderv
force-pushed
the
website/sidebar-global
branch
from
fc8b370
to
e91483a
Compare
|
@cderv Before we merge this, can you add a regression test? |
|
Oh sure. My bad. I believe we can run project tests now. |
A sidebar item with only single id should apply only to this one Related to #5689
cderv
force-pushed
the
website/sidebar-global
branch
from
e91483a
to
4cb2b21
Compare
|
I reverted this PR in 4ee3e32 because it broke quarto-web. |
This was referenced Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
global sidebard is detected by
undefinedid, so we need to compute id from title not too early, and in a a way that does not modify initial configCloses #9242 and closes #9728
This is currently a proposal built on top of unmerged #8871 by @dragonstyle to deal with #8869 and follow up on #5689
I believe we can do what was supposed to be done in #8871, but we need to make sure that we don't modify initial
navigation.sidebarscontent's id.I still think we could consider adding a more explicit
globalconfig fortrueorfalseto make this more clear.This requires some testing to be sure it works ok this time. Opening this draft PR to discuss and have thoughts on this change.