Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make update(...) functions to return self #86

Closed
pfumagalli opened this issue Apr 12, 2015 · 2 comments · Fixed by #87
Closed

Make update(...) functions to return self #86

pfumagalli opened this issue Apr 12, 2015 · 2 comments · Fixed by #87

Comments

@pfumagalli
Copy link

It would be über nice if signer.update(...) and verifier.update(...) were to return self so that methods could be easily chained like:

var signature = ursa.createSigner('SHA256')
                    .update('foo')
                    .update('bar')
                    .sign(...);

Should I submit a PR?
@quartzjer
Copy link
Collaborator

Yeah, that would be great :)

pfumagalli pushed a commit to pfumagalli/ursa that referenced this issue Apr 15, 2015
Have the update(...) method of Signer and Verifier to return this.
5fc1e97 
This helps with method chaining, like:

```javascript
var signature = ursa.createSigner('SHA256')
                    .update('foo')
                    .update('bar')
                    .sign(...);
```

Fixes JoshKaufman#86
@pfumagalli pfumagalli mentioned this issue Apr 15, 2015
Merged
@pfumagalli
Copy link
Author

Pull request in #87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Have the update(...) method of Signer and Verifier to return this. pfumagalli/ursa
2 participants
@quartzjer @pfumagalli