feat: make json schema definition stricter

quarylabs · May 23, 2024 · ee5441a · ee5441a
1 parent a9ce531
commit ee5441a
Show file tree

Hide file tree

Showing 129 changed files with 782 additions and 672 deletions.
diff --git a/buf.gen.yaml b/buf.gen.yaml
@@ -16,6 +16,8 @@ plugins:
     out: proto/gen/rust/src
   - out: proto/gen/json_schema
     plugin: buf.build/community/chrusty-jsonschema
+    opt:
+      - disallow_additional_properties
   - plugin: buf.build/bufbuild/connect-es
     out: proto/gen/es
     opt:

diff --git a/proto/gen/json_schema/AddColumnTestToModelOrSourceColumnRequest.json b/proto/gen/json_schema/AddColumnTestToModelOrSourceColumnRequest.json
@@ -15,10 +15,10 @@
                 },
                 "column_test": {
                     "$ref": "#/definitions/quary.service.v1.ColumnTest",
-                    "additionalProperties": true
+                    "additionalProperties": false
                 }
             },
-            "additionalProperties": true,
+            "additionalProperties": false,
             "type": "object",
             "title": "Add Column Test To Model Or Source Column Request"
         },
@@ -34,7 +34,7 @@
                     "type": "object"
                 }
             },
-            "additionalProperties": true,
+            "additionalProperties": false,
             "type": "object",
             "title": "Column Test"
         }

diff --git a/proto/gen/json_schema/AddColumnTestToModelOrSourceColumnResponse.json b/proto/gen/json_schema/AddColumnTestToModelOrSourceColumnResponse.json
@@ -3,7 +3,7 @@
     "$ref": "#/definitions/AddColumnTestToModelOrSourceColumnResponse",
     "definitions": {
         "AddColumnTestToModelOrSourceColumnResponse": {
-            "additionalProperties": true,
+            "additionalProperties": false,
             "type": "object",
             "title": "Add Column Test To Model Or Source Column Response"
         }

diff --git a/proto/gen/json_schema/AddColumnToModelOrSourceRequest.json b/proto/gen/json_schema/AddColumnToModelOrSourceRequest.json
@@ -14,7 +14,7 @@
                     "type": "string"
                 }
             },
-            "additionalProperties": true,
+            "additionalProperties": false,
             "type": "object",
             "title": "Add Column To Model Or Source Request"
         }

diff --git a/proto/gen/json_schema/AddColumnToModelOrSourceResponse.json b/proto/gen/json_schema/AddColumnToModelOrSourceResponse.json
@@ -3,7 +3,7 @@
     "$ref": "#/definitions/AddColumnToModelOrSourceResponse",
     "definitions": {
         "AddColumnToModelOrSourceResponse": {
-            "additionalProperties": true,
+            "additionalProperties": false,
             "type": "object",
             "title": "Add Column To Model Or Source Response"
         }

diff --git a/proto/gen/json_schema/BigQueryDataset.json b/proto/gen/json_schema/BigQueryDataset.json
@@ -14,7 +14,7 @@
                 },
                 "dataset_reference": {
                     "$ref": "#/definitions/quary.service.v1.BigQueryDatasetReference",
-                    "additionalProperties": true,
+                    "additionalProperties": false,
                     "description": "The dataset reference. Use this property to access specific parts of the dataset's ID, such as project ID or dataset ID."
                 },
                 "friendly_name": {
@@ -33,7 +33,7 @@
                     "description": "The geographic location where the dataset resides."
                 }
             },
-            "additionalProperties": true,
+            "additionalProperties": false,
             "type": "object",
             "title": "Big Query Dataset",
             "description": "Dataset API Documentation: https://cloud.google.com/bigquery/docs/reference/rest/v2/datasets/list"
@@ -47,7 +47,7 @@
                     "type": "string"
                 }
             },
-            "additionalProperties": true,
+            "additionalProperties": false,
             "type": "object",
             "title": "Big Query Dataset Reference",
             "description": "Dataset Reference API Documentation: https://cloud.google.com/bigquery/docs/reference/rest/v2/datasets#DatasetReference"

diff --git a/proto/gen/json_schema/BigQueryDatasetReference.json b/proto/gen/json_schema/BigQueryDatasetReference.json
@@ -11,7 +11,7 @@
                     "type": "string"
                 }
             },
-            "additionalProperties": true,
+            "additionalProperties": false,
             "type": "object",
             "title": "Big Query Dataset Reference",
             "description": "Dataset Reference API Documentation: https://cloud.google.com/bigquery/docs/reference/rest/v2/datasets#DatasetReference"

diff --git a/proto/gen/json_schema/BigQueryError.json b/proto/gen/json_schema/BigQueryError.json
@@ -21,7 +21,7 @@
                     "description": "A human-readable description of the error."
                 }
             },
-            "additionalProperties": true,
+            "additionalProperties": false,
             "type": "object",
             "title": "Big Query Error",
             "description": "BigQueryError API Documentation: https://cloud.google.com/bigquery/docs/reference/rest/v2/ErrorProto"

diff --git a/proto/gen/json_schema/BigQueryFieldValue.json b/proto/gen/json_schema/BigQueryFieldValue.json
@@ -13,7 +13,7 @@
                     "description": "Represents the 'v' in a JSON object"
                 }
             },
-            "additionalProperties": true,
+            "additionalProperties": false,
             "type": "object",
             "title": "Big Query Field Value"
         }

diff --git a/proto/gen/json_schema/BigQueryJob.json b/proto/gen/json_schema/BigQueryJob.json
@@ -22,16 +22,16 @@
                 },
                 "job_reference": {
                     "$ref": "#/definitions/quary.service.v1.BigQueryJobReference",
-                    "additionalProperties": true,
+                    "additionalProperties": false,
                     "description": "A reference uniquely identifying the job."
                 },
                 "status": {
                     "$ref": "#/definitions/quary.service.v1.BigQueryJobStatus",
-                    "additionalProperties": true,
+                    "additionalProperties": false,
                     "description": "Information about the job, including starting time and ending time of the job."
                 }
             },
-            "additionalProperties": true,
+            "additionalProperties": false,
             "type": "object",
             "title": "Big Query Job",
             "description": "Job API Documentation: https://cloud.google.com/bigquery/docs/reference/rest/v2/Job"
@@ -51,7 +51,7 @@
                     "description": "The geographic location of the job."
                 }
             },
-            "additionalProperties": true,
+            "additionalProperties": false,
             "type": "object",
             "title": "Big Query Job Reference",
             "description": "JobReference API Documentation: https://cloud.google.com/bigquery/docs/reference/rest/v2/JobReference"
@@ -71,7 +71,7 @@
                     "description": "The final error result of the job as a human-readable string."
                 }
             },
-            "additionalProperties": true,
+            "additionalProperties": false,
             "type": "object",
             "title": "Big Query Job Status",
             "description": "JobStatus API Documentation: https://cloud.google.com/bigquery/docs/reference/rest/v2/JobStatus"

diff --git a/proto/gen/json_schema/BigQueryJobReference.json b/proto/gen/json_schema/BigQueryJobReference.json
@@ -17,7 +17,7 @@
                     "description": "The geographic location of the job."
                 }
             },
-            "additionalProperties": true,
+            "additionalProperties": false,
             "type": "object",
             "title": "Big Query Job Reference",
             "description": "JobReference API Documentation: https://cloud.google.com/bigquery/docs/reference/rest/v2/JobReference"

diff --git a/proto/gen/json_schema/BigQueryJobResults.json b/proto/gen/json_schema/BigQueryJobResults.json
@@ -10,12 +10,12 @@
                 },
                 "schema": {
                     "$ref": "#/definitions/quary.service.v1.BigQueryTableSchema",
-                    "additionalProperties": true,
+                    "additionalProperties": false,
                     "description": "The schema of the results. Present only when the query completes successfully."
                 },
                 "job_reference": {
                     "$ref": "#/definitions/quary.service.v1.BigQueryJobReference",
-                    "additionalProperties": true,
+                    "additionalProperties": false,
                     "description": "A reference uniquely identifying the job."
                 },
                 "total_rows": {
@@ -30,6 +30,7 @@
                     "items": {
                         "$ref": "#/definitions/quary.service.v1.BigQueryTableRow"
                     },
+                    "additionalProperties": false,
                     "type": "array",
                     "description": "An object with as many results as can be contained within the maximum permitted reply size. To get any additional rows, you can call GetQueryResults and specify the jobReference returned above."
                 },
@@ -41,6 +42,7 @@
                     "items": {
                         "$ref": "#/definitions/quary.service.v1.BigQueryError"
                     },
+                    "additionalProperties": false,
                     "type": "array",
                     "description": "The first errors encountered during the running of the job. The final message includes the number of errors encountered."
                 },
@@ -53,7 +55,7 @@
                     "description": "The number of rows affected by a DML statement. Present only for DML statements INSERT, UPDATE or DELETE."
                 }
             },
-            "additionalProperties": true,
+            "additionalProperties": false,
             "type": "object",
             "title": "Big Query Job Results",
             "description": "BigQueryJobResults API Documentation: https://cloud.google.com/bigquery/docs/reference/rest/v2/jobs/getQueryResults"
@@ -77,7 +79,7 @@
                     "description": "A human-readable description of the error."
                 }
             },
-            "additionalProperties": true,
+            "additionalProperties": false,
             "type": "object",
             "title": "Big Query Error",
             "description": "BigQueryError API Documentation: https://cloud.google.com/bigquery/docs/reference/rest/v2/ErrorProto"
@@ -93,7 +95,7 @@
                     "description": "Represents the 'v' in a JSON object"
                 }
             },
-            "additionalProperties": true,
+            "additionalProperties": false,
             "type": "object",
             "title": "Big Query Field Value"
         },
@@ -112,7 +114,7 @@
                     "description": "The geographic location of the job."
                 }
             },
-            "additionalProperties": true,
+            "additionalProperties": false,
             "type": "object",
             "title": "Big Query Job Reference",
             "description": "JobReference API Documentation: https://cloud.google.com/bigquery/docs/reference/rest/v2/JobReference"
@@ -135,6 +137,7 @@
                     "items": {
                         "$ref": "#/definitions/quary.service.v1.BigQueryTableField"
                     },
+                    "additionalProperties": false,
                     "type": "array",
                     "description": "Describes the nested schema fields if the type property is set to RECORD."
                 },
@@ -143,7 +146,7 @@
                     "description": "The field description."
                 }
             },
-            "additionalProperties": true,
+            "additionalProperties": false,
             "type": "object",
             "title": "Big Query Table Field",
             "description": "Table Field API Documentation: https://cloud.google.com/bigquery/docs/reference/rest/v2/tables#TableFieldSchema"
@@ -154,11 +157,12 @@
                     "items": {
                         "$ref": "#/definitions/quary.service.v1.BigQueryFieldValue"
                     },
+                    "additionalProperties": false,
                     "type": "array",
                     "description": "Represents a single row as a series of field-value pairs"
                 }
             },
-            "additionalProperties": true,
+            "additionalProperties": false,
             "type": "object",
             "title": "Big Query Table Row"
         },
@@ -174,6 +178,7 @@
                     "items": {
                         "$ref": "#/definitions/quary.service.v1.BigQueryTableField"
                     },
+                    "additionalProperties": false,
                     "type": "array",
                     "description": "Describes the fields in a table."
                 },
@@ -182,7 +187,7 @@
                     "description": "The field description."
                 }
             },
-            "additionalProperties": true,
+            "additionalProperties": false,
             "type": "object",
             "title": "Big Query Table Schema",
             "description": "Table Schema API Documentation: https://cloud.google.com/bigquery/docs/reference/rest/v2/tables#TableSchema"

diff --git a/proto/gen/json_schema/BigQueryJobStatus.json b/proto/gen/json_schema/BigQueryJobStatus.json
@@ -17,7 +17,7 @@
                     "description": "The final error result of the job as a human-readable string."
                 }
             },
-            "additionalProperties": true,
+            "additionalProperties": false,
             "type": "object",
             "title": "Big Query Job Status",
             "description": "JobStatus API Documentation: https://cloud.google.com/bigquery/docs/reference/rest/v2/JobStatus"

diff --git a/proto/gen/json_schema/BigQueryOauthToken.json b/proto/gen/json_schema/BigQueryOauthToken.json
@@ -16,7 +16,7 @@
                     "description": "absolute time the token expires"
                 }
             },
-            "additionalProperties": true,
+            "additionalProperties": false,
             "type": "object",
             "title": "Big Query Oauth Token",
             "description": "Google Oauth 2.0 token API Documentation: https://developers.google.com/identity/protocols/oauth2/web-server#httprest"

diff --git a/proto/gen/json_schema/BigQueryOauthTokenRefresh.json b/proto/gen/json_schema/BigQueryOauthTokenRefresh.json
@@ -13,7 +13,7 @@
                     "description": "absolute time the token expires"
                 }
             },
-            "additionalProperties": true,
+            "additionalProperties": false,
             "type": "object",
             "title": "Big Query Oauth Token Refresh"
         }

diff --git a/proto/gen/json_schema/BigQueryProject.json b/proto/gen/json_schema/BigQueryProject.json
@@ -18,15 +18,15 @@
                 },
                 "project_reference": {
                     "$ref": "#/definitions/quary.service.v1.BigQueryProjectReference",
-                    "additionalProperties": true,
+                    "additionalProperties": false,
                     "description": "A unique reference to a project."
                 },
                 "friendly_name": {
                     "type": "string",
                     "description": "A descriptive name for this project."
                 }
             },
-            "additionalProperties": true,
+            "additionalProperties": false,
             "type": "object",
             "title": "Big Query Project",
             "description": "Project API Documentation: https://cloud.google.com/bigquery/docs/reference/rest/v2/projects/list"
@@ -37,7 +37,7 @@
                     "type": "string"
                 }
             },
-            "additionalProperties": true,
+            "additionalProperties": false,
             "type": "object",
             "title": "------------------\n BigQuery Responses\n ------------------",
             "description": "------------------ BigQuery Responses ------------------"

diff --git a/proto/gen/json_schema/BigQueryProjectReference.json b/proto/gen/json_schema/BigQueryProjectReference.json
@@ -8,7 +8,7 @@
                     "type": "string"
                 }
             },
-            "additionalProperties": true,
+            "additionalProperties": false,
             "type": "object",
             "title": "------------------\n BigQuery Responses\n ------------------",
             "description": "------------------ BigQuery Responses ------------------"

diff --git a/proto/gen/json_schema/BigQueryTable.json b/proto/gen/json_schema/BigQueryTable.json
@@ -14,7 +14,7 @@
                 },
                 "table_reference": {
                     "$ref": "#/definitions/quary.service.v1.BigQueryTableReference",
-                    "additionalProperties": true,
+                    "additionalProperties": false,
                     "description": "A reference uniquely identifying the table."
                 },
                 "type": {
@@ -26,7 +26,7 @@
                     "description": "The time when this table was created, in milliseconds since the epoch."
                 }
             },
-            "additionalProperties": true,
+            "additionalProperties": false,
             "type": "object",
             "title": "Big Query Table",
             "description": "Table API Documentation: https://cloud.google.com/bigquery/docs/reference/rest/v2/tables/list"
@@ -43,7 +43,7 @@
                     "type": "string"
                 }
             },
-            "additionalProperties": true,
+            "additionalProperties": false,
             "type": "object",
             "title": "Big Query Table Reference",
             "description": "Table Reference API Documentation: https://cloud.google.com/bigquery/docs/reference/rest/v2/tables#TableReference"

diff --git a/proto/gen/json_schema/BigQueryTableField.json b/proto/gen/json_schema/BigQueryTableField.json
@@ -20,6 +20,7 @@
                     "items": {
                         "$ref": "#/definitions/BigQueryTableField"
                     },
+                    "additionalProperties": false,
                     "type": "array",
                     "description": "Describes the nested schema fields if the type property is set to RECORD."
                 },
@@ -28,7 +29,7 @@
                     "description": "The field description."
                 }
             },
-            "additionalProperties": true,
+            "additionalProperties": false,
             "type": "object",
             "title": "Big Query Table Field",
             "description": "Table Field API Documentation: https://cloud.google.com/bigquery/docs/reference/rest/v2/tables#TableFieldSchema"

diff --git a/proto/gen/json_schema/BigQueryTableReference.json b/proto/gen/json_schema/BigQueryTableReference.json
@@ -14,7 +14,7 @@
                     "type": "string"
                 }
             },
-            "additionalProperties": true,
+            "additionalProperties": false,
             "type": "object",
             "title": "Big Query Table Reference",
             "description": "Table Reference API Documentation: https://cloud.google.com/bigquery/docs/reference/rest/v2/tables#TableReference"