New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lsp): support for config in wasm #396

Merged

benfdking merged 3 commits into main from feat/support-config-wasm

Jun 20, 2024

+133 −34

Collaborator

gvozdvmozgu commented Jun 19, 2024

No description provided.

github-actions bot commented Jun 19, 2024

Benchmark for `4361b2c`

Click to view benchmark

Test	Base	PR	%
DepthMap::from_parent	208.0±1.95µs	208.8±3.88µs	+0.38%
fix_complex_query	21.8±0.39ms	22.0±0.85ms	+0.92%
parse_complex_query	272.5±5.04µs	273.0±6.60µs	+0.18%
parse_expression_recursion	301.6±5.97µs	304.5±11.78µs	+0.96%
parse_simple_query	258.6±7.44µs	271.7±30.39µs	+5.07%

gvozdvmozgu added 3 commits

June 20, 2024 03:31


          feat(lsp): support for config in wasm

6c8a4d0

9d0a824


          feat: watching configuration changes

51e434b

gvozdvmozgu force-pushed the feat/support-config-wasm branch from 9b188ff to 51e434b Compare

June 20, 2024 07:32

gvozdvmozgu marked this pull request as ready for review

June 20, 2024 07:33

github-actions bot commented Jun 20, 2024

Benchmark for `8e122fd`

Click to view benchmark

Test	Base	PR	%
DepthMap::from_parent	212.4±2.33µs	210.0±3.74µs	-1.13%
fix_complex_query	21.7±0.10ms	21.7±0.18ms	0.00%
parse_complex_query	276.8±7.59µs	280.0±7.53µs	+1.16%
parse_expression_recursion	303.3±3.41µs	305.9±5.64µs	+0.86%
parse_simple_query	266.0±19.52µs	267.5±14.78µs	+0.56%

Collaborator

benfdking commented Jun 20, 2024

Very nice work! 🔥

benfdking added this pull request to the merge queue

Merged via the queue into main with commit 6d0c97b

11 checks passed

benfdking deleted the feat/support-config-wasm branch

June 20, 2024 07:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment