Update get_min_ratio_per_position math logic #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaurensKubat
reviewed
Mar 8, 2024
## 1. Overview <!-- What are you changing, removing, or adding in this review? --> ## 2. Implementation details <!-- Describe the implementation (highlights only) as well as design rationale. --> ## 3. How to test/use <!-- How can people test/use this? --> ## 4. Checklist <!-- Checklist for PR author(s). --> - [ ] Does the Readme need to be updated? ## 5. Limitations (optional) <!-- Describe any limitation of the capabilities listed in the Overview section. --> ## 6. Future Work (optional) <!-- Describe follow up work, if any. --> --------- Co-authored-by: Laurens <32776056+LaurensKubat@users.noreply.github.com>
njerschow
changed the title
LaurensKubat
reviewed
Apr 4, 2024
## 1. Overview <!-- What are you changing, removing, or adding in this review? --> ## 2. Implementation details <!-- Describe the implementation (highlights only) as well as design rationale. --> ## 3. How to test/use <!-- How can people test/use this? --> ## 4. Checklist <!-- Checklist for PR author(s). --> - [ ] Does the Readme need to be updated? ## 5. Limitations (optional) <!-- Describe any limitation of the capabilities listed in the Overview section. --> ## 6. Future Work (optional) <!-- Describe follow up work, if any. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Overview
Improving the logic within the get_min_ratio_per_position function to remove the dependency on an arbitrary liquidity amount. Algebra in README
2. Implementation details
After deriving the equation, we simply needed to rewrite the math according to the new formulas
3. How to test/use
cargo test-tube
4. Checklist
5. Limitations (optional)
6. Future Work (optional)