Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/fee splitter #599

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Feat/fee splitter #599

wants to merge 17 commits into from

Conversation

LaurensKubat
Copy link
Contributor

@LaurensKubat LaurensKubat commented May 13, 2024

1. Overview

Adds a contract that splits fees from the contract balance and sends those to the preset receivers

2. Implementation details

Adds a contract that supports claiming as well as receiving funds via bank transfers.
The claiming implementation works by calling a contract with an arbitrary message, thus this contract would be extremely unsafe for any CW20 usage, but would well for native tokens since we can force the tokens sent to 0 for native tokens

3. How to test/use

This contract has very little cross contract test, so almost all functionality can be tested in either a unit test or a simple multi test

4. Checklist

  • Does the Readme need to be updated?

5. Limitations (optional)

6. Future Work (optional)

Copy link
Collaborator

@arhamchordia arhamchordia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do we keep the claim feature enable by default?

@LaurensKubat
Copy link
Contributor Author

LaurensKubat commented May 20, 2024

Looks good. Do we keep the claim feature enable by default?

Depends on how we want to deploy, if we write all strategists claims with bank sends, that shouldn't be necessary. The reason I made is optional is because in general, reducing complexity surface is a good thing. So If we can not do so, I would strongly prefer to not do so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants